From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60481)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1Yukdm-0005pc-Uh
	for qemu-devel@nongnu.org; Tue, 19 May 2015 12:45:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1Yukdi-00040E-OP
	for qemu-devel@nongnu.org; Tue, 19 May 2015 12:45:14 -0400
Received: from mail-wg0-f42.google.com ([74.125.82.42]:33053)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1Yukdi-000407-Hu
	for qemu-devel@nongnu.org; Tue, 19 May 2015 12:45:10 -0400
Received: by wgjc11 with SMTP id c11so24795755wgj.0
	for <qemu-devel@nongnu.org>; Tue, 19 May 2015 09:45:10 -0700 (PDT)
Message-ID: <555B688C.2000502@linaro.org>
Date: Tue, 19 May 2015 18:45:00 +0200
From: Eric Auger <eric.auger@linaro.org>
MIME-Version: 1.0
References: <1431624430-3996-1-git-send-email-ashoks@broadcom.com>
	<00c401d08eda$57394490$05abcdb0$@samsung.com>
In-Reply-To: <00c401d08eda$57394490$05abcdb0$@samsung.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: Added preliminary GICv3
 support for kvm mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Fedin <p.fedin@samsung.com>, 'Ashok Kumar' <ashoks@broadcom.com>, qemu-devel@nongnu.org
Cc: 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>

On 05/15/2015 08:42 AM, Pavel Fedin wrote:
>  Hello!
> 
>> Added -M virt,gicversion=2,3 property to configure GICv2 or GICv3.
>> GICv3 save/restore is not supported as vgic-v3-emul.c is yet to support
>> them.
>>
>> Signed-off-by: Ashok Kumar <ashoks@broadcom.com>
> 
>  I also work on this, just not published yet. Some notes about your version:
> 1. May be there should be hw/intc/arm_gicv3_kvm.c file created for GICv3? As far as i can
> see, save/restore code should differ a lot.
Hi,

I agree with you Pavel, the code currently uses a GICState supporting
max 8 CPU. So looks like we should use Shlomo's version and move code in
a new arm_gicv3_kvm.c.

Best Regards

Eric
> 2. kvm_arch_irqchip_create() should probe only for type we want to get. It has to be
> passed there somehow from the virt machine initializer. And, if we want GICv3, then upon
> failure it should return error, not zero. This is because when kvm_arch_irqchip_create()
> returns zero, a fallback code is used, which will create GICv2.
> 3. Perhaps you should base your work on these patch sets:
>     https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg00941.html
>     https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01505.html
> 
>  I added Shlomo to cc because he might also be interested.
> 
> Kind regards,
> Pavel Fedin
> Expert Engineer
> Samsung Electronics Research center Russia
> 
> 
>