From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YumMn-0001ez-CK for qemu-devel@nongnu.org; Tue, 19 May 2015 14:35:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YumMi-0006Vj-NQ for qemu-devel@nongnu.org; Tue, 19 May 2015 14:35:47 -0400 Received: from e18.ny.us.ibm.com ([129.33.205.208]:35624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YumMi-0006VP-JL for qemu-devel@nongnu.org; Tue, 19 May 2015 14:35:44 -0400 Received: from /spool/local by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 19 May 2015 14:35:44 -0400 Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 5ABBFC90041 for ; Tue, 19 May 2015 14:26:49 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4JIZfs957737268 for ; Tue, 19 May 2015 18:35:41 GMT Received: from d01av02.pok.ibm.com (localhost [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4JIZfgY018180 for ; Tue, 19 May 2015 14:35:41 -0400 Message-ID: <555B8286.504@linux.vnet.ibm.com> Date: Tue, 19 May 2015 13:35:50 -0500 From: "Michael R. Hines" MIME-Version: 1.0 References: <1429545445-28216-1-git-send-email-dgilbert@redhat.com> <1429545445-28216-7-git-send-email-dgilbert@redhat.com> In-Reply-To: <1429545445-28216-7-git-send-email-dgilbert@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/10] Remove unneeded memset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, arei.gonglei@huawei.com, mrhines@us.ibm.com, quintela@redhat.com On 04/20/2015 10:57 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Signed-off-by: Dr. David Alan Gilbert > --- > migration/rdma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/migration/rdma.c b/migration/rdma.c > index e43fae4..4f7dd0d 100644 > --- a/migration/rdma.c > +++ b/migration/rdma.c > @@ -2469,7 +2469,6 @@ static void *qemu_rdma_data_init(const char *host_port, Error **errp) > > if (host_port) { > rdma = g_malloc0(sizeof(RDMAContext)); > - memset(rdma, 0, sizeof(RDMAContext)); > rdma->current_index = -1; > rdma->current_chunk = -1; > Reviewed-by: Michael R. Hines