From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YumcH-0003xc-81 for qemu-devel@nongnu.org; Tue, 19 May 2015 14:51:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YumcC-0004sK-2n for qemu-devel@nongnu.org; Tue, 19 May 2015 14:51:49 -0400 Received: from e17.ny.us.ibm.com ([129.33.205.207]:47434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YumcB-0004s5-UV for qemu-devel@nongnu.org; Tue, 19 May 2015 14:51:44 -0400 Received: from /spool/local by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 19 May 2015 14:51:43 -0400 Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 9158F38C8046 for ; Tue, 19 May 2015 14:51:40 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4JIpdXc65274078 for ; Tue, 19 May 2015 18:51:39 GMT Received: from d01av02.pok.ibm.com (localhost [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4JIpdM2028225 for ; Tue, 19 May 2015 14:51:39 -0400 Message-ID: <555B8645.7040305@linux.vnet.ibm.com> Date: Tue, 19 May 2015 13:51:49 -0500 From: "Michael R. Hines" MIME-Version: 1.0 References: <1429545445-28216-1-git-send-email-dgilbert@redhat.com> <1429545445-28216-10-git-send-email-dgilbert@redhat.com> In-Reply-To: <1429545445-28216-10-git-send-email-dgilbert@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/10] Sort destination RAMBlocks to be the same as the source List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, arei.gonglei@huawei.com, mrhines@us.ibm.com, quintela@redhat.com On 04/20/2015 10:57 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Use the order of incoming RAMBlocks from the source to record > an index number; that then allows us to sort the destination > local RAMBlock list to match the source. > > Now that the RAMBlocks are known to be in the same order, this > simplifies the RDMA Registration step which previously tried to > match RAMBlocks based on offset (which isn't guaranteed to match). OK, so, what's the reason for sorting? If the offset is not gauranteed to match (based on a new patch that I assume you have coming), then we need to index into the hashtable based on something that does match, such as the name you added or some other key.