From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuoGX-0000qy-UY for qemu-devel@nongnu.org; Tue, 19 May 2015 16:37:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuoGS-0008Uo-Px for qemu-devel@nongnu.org; Tue, 19 May 2015 16:37:29 -0400 Message-ID: <555B9F02.3060509@redhat.com> Date: Tue, 19 May 2015 16:37:22 -0400 From: John Snow MIME-Version: 1.0 References: <1432049762-2184-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1432049762-2184-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/8] fdc: Clean up and fix command processing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org On 05/19/2015 11:35 AM, Kevin Wolf wrote: > This series fixes the real bug that caused CVE-2015-3456, and does some > cleanup in the FIFO access functions to make the command processing more > obvious. > > Kevin Wolf (8): > fdc: Rename fdctrl_reset_fifo() to fdctrl_to_command_phase() > fdc: Rename fdctrl_set_fifo() to fdctrl_to_result_phase() > fdc: Introduce fdctrl->phase > fdc: Use phase in fdctrl_write_data() > fdc: Code cleanup in fdctrl_write_data() > fdc: Disentangle phases in fdctrl_read_data() > fdc: Fix MSR.RQM flag > fdc-test: Test state for existing cases more thoroughly > > hw/block/fdc.c | 235 +++++++++++++++++++++++++++++++++++++------------------ > tests/fdc-test.c | 34 ++++++++ > 2 files changed, 192 insertions(+), 77 deletions(-) > This is just the cover letter, but I might not leave the implication dangling that the CVE-2015-3456 bug remains to be patched, or that the vulnerability still exists in the current codebase. So for posterity: This patch series is a thorough cleanup of the code that was patched to prevent the CVE-2015-3456 vulnerability. Thanks! --js