From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuoHv-0002te-5Y for qemu-devel@nongnu.org; Tue, 19 May 2015 16:38:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuoHq-0000UY-7L for qemu-devel@nongnu.org; Tue, 19 May 2015 16:38:55 -0400 Message-ID: <555B9F58.4040006@redhat.com> Date: Tue, 19 May 2015 16:38:48 -0400 From: John Snow MIME-Version: 1.0 References: <1432049762-2184-1-git-send-email-kwolf@redhat.com> <1432049762-2184-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1432049762-2184-4-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org On 05/19/2015 11:35 AM, Kevin Wolf wrote: > The floppy controller spec describes three different controller phases, > which are currently not explicitly modelled in our emulation. Instead, > each phase is represented by a combination of flags in registers. > > This patch makes explicit in which phase the controller currently is. > > Signed-off-by: Kevin Wolf > --- > hw/block/fdc.c | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/hw/block/fdc.c b/hw/block/fdc.c > index 8c41434..4d4868e 100644 > --- a/hw/block/fdc.c > +++ b/hw/block/fdc.c [snip] Reviewed-by: John Snow