From: John Snow <jsnow@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/8] fdc: Use phase in fdctrl_write_data()
Date: Tue, 19 May 2015 16:39:12 -0400 [thread overview]
Message-ID: <555B9F70.9060404@redhat.com> (raw)
In-Reply-To: <1432049762-2184-5-git-send-email-kwolf@redhat.com>
On 05/19/2015 11:35 AM, Kevin Wolf wrote:
> Instead of relying on a flag in the MSR to distinguish controller phases,
> use the explicit phase that we store now. Assertions of the right MSR
> flags are added.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> hw/block/fdc.c | 67 ++++++++++++++++++++++++++++++++++------------------------
> 1 file changed, 39 insertions(+), 28 deletions(-)
>
> diff --git a/hw/block/fdc.c b/hw/block/fdc.c
> index 4d4868e..a13e0ce 100644
> --- a/hw/block/fdc.c
> +++ b/hw/block/fdc.c
[snip]
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2015-05-19 20:39 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 15:35 [Qemu-devel] [PATCH 0/8] fdc: Clean up and fix command processing Kevin Wolf
2015-05-19 15:35 ` [Qemu-devel] [PATCH 1/8] fdc: Rename fdctrl_reset_fifo() to fdctrl_to_command_phase() Kevin Wolf
2015-05-19 20:37 ` John Snow
2015-05-19 15:35 ` [Qemu-devel] [PATCH 2/8] fdc: Rename fdctrl_set_fifo() to fdctrl_to_result_phase() Kevin Wolf
2015-05-19 20:38 ` John Snow
2015-05-19 15:35 ` [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase Kevin Wolf
2015-05-19 20:38 ` John Snow
2015-05-19 20:44 ` Peter Maydell
2015-05-19 20:52 ` John Snow
2015-05-19 20:57 ` Peter Maydell
2015-05-20 7:54 ` Kevin Wolf
2015-05-20 8:06 ` Peter Maydell
2015-05-20 8:43 ` Kevin Wolf
2015-05-20 9:24 ` Peter Maydell
2015-05-20 11:55 ` John Snow
2015-05-20 12:07 ` Peter Maydell
2015-05-21 9:42 ` Kevin Wolf
2015-05-21 9:47 ` Dr. David Alan Gilbert
2015-05-21 10:11 ` Peter Maydell
2015-05-21 10:31 ` Kevin Wolf
2015-05-21 11:09 ` Markus Armbruster
2015-05-21 11:14 ` Peter Maydell
2015-05-21 11:37 ` Dr. David Alan Gilbert
2015-05-19 15:35 ` [Qemu-devel] [PATCH 4/8] fdc: Use phase in fdctrl_write_data() Kevin Wolf
2015-05-19 20:39 ` John Snow [this message]
2015-05-19 20:52 ` Peter Maydell
2015-05-19 15:35 ` [Qemu-devel] [PATCH 5/8] fdc: Code cleanup " Kevin Wolf
2015-05-19 20:40 ` John Snow
2015-05-20 8:18 ` Kevin Wolf
2015-05-19 15:36 ` [Qemu-devel] [PATCH 6/8] fdc: Disentangle phases in fdctrl_read_data() Kevin Wolf
2015-05-19 20:40 ` John Snow
2015-05-20 8:25 ` Kevin Wolf
2015-05-20 11:59 ` John Snow
2015-05-19 15:36 ` [Qemu-devel] [PATCH 7/8] fdc: Fix MSR.RQM flag Kevin Wolf
2015-05-19 20:40 ` John Snow
2015-05-20 8:14 ` Kevin Wolf
2015-05-20 11:58 ` John Snow
2015-05-19 15:36 ` [Qemu-devel] [PATCH 8/8] fdc-test: Test state for existing cases more thoroughly Kevin Wolf
2015-05-19 20:41 ` John Snow
2015-05-19 20:37 ` [Qemu-devel] [PATCH 0/8] fdc: Clean up and fix command processing John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555B9F70.9060404@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).