From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuoIF-0003Uq-TF for qemu-devel@nongnu.org; Tue, 19 May 2015 16:39:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuoIE-0000ef-DI for qemu-devel@nongnu.org; Tue, 19 May 2015 16:39:15 -0400 Message-ID: <555B9F70.9060404@redhat.com> Date: Tue, 19 May 2015 16:39:12 -0400 From: John Snow MIME-Version: 1.0 References: <1432049762-2184-1-git-send-email-kwolf@redhat.com> <1432049762-2184-5-git-send-email-kwolf@redhat.com> In-Reply-To: <1432049762-2184-5-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/8] fdc: Use phase in fdctrl_write_data() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org On 05/19/2015 11:35 AM, Kevin Wolf wrote: > Instead of relying on a flag in the MSR to distinguish controller phases, > use the explicit phase that we store now. Assertions of the right MSR > flags are added. > > Signed-off-by: Kevin Wolf > --- > hw/block/fdc.c | 67 ++++++++++++++++++++++++++++++++++------------------------ > 1 file changed, 39 insertions(+), 28 deletions(-) > > diff --git a/hw/block/fdc.c b/hw/block/fdc.c > index 4d4868e..a13e0ce 100644 > --- a/hw/block/fdc.c > +++ b/hw/block/fdc.c [snip] Reviewed-by: John Snow