From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yuojn-0004O1-R8 for qemu-devel@nongnu.org; Tue, 19 May 2015 17:07:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yuojk-0004RW-Hp for qemu-devel@nongnu.org; Tue, 19 May 2015 17:07:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yuojk-0004RI-Ay for qemu-devel@nongnu.org; Tue, 19 May 2015 17:07:40 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4JL7cf9031562 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 19 May 2015 17:07:39 -0400 Message-ID: <555BA619.8090004@redhat.com> Date: Tue, 19 May 2015 17:07:37 -0400 From: John Snow MIME-Version: 1.0 References: <1431470173-30847-1-git-send-email-jsnow@redhat.com> <20150518095707.GB2679@stefanha-thinkpad.redhat.com> In-Reply-To: <20150518095707.GB2679@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/1] ahci: do not remap clb/fis unconditionally List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On 05/18/2015 05:57 AM, Stefan Hajnoczi wrote: > On Tue, May 12, 2015 at 06:36:12PM -0400, John Snow wrote: >> This continues the IOMMU fix from 2.3, where we should not >> attempt to remap the CLB or FIS RX buffers if the AHCI device is >> currently running. >> >> The same applies to migration: keep our mitts off these >> registers unless the device is supposed to be on. >> >> Does not impact backwards compatibility for the AHCI device. >> >> == For convenience, this branch is available at: >> https://github.com/jnsnow/qemu.git branch ahci-iommu >> https://github.com/jnsnow/qemu/tree/ahci-iommu >> >> This version is tagged ahci-iommu-v1: >> https://github.com/jnsnow/qemu/releases/tag/ahci-iommu-v1 == >> >> John Snow (1): ahci: do not remap clb/fis unconditionally >> >> hw/ide/ahci.c | 88 >> ++++++++++++++++++++++++++++++++++++++++++----------------- 1 >> file changed, 63 insertions(+), 25 deletions(-) >> >> -- 2.1.0 >> > > Reviewed-by: Stefan Hajnoczi > Thanks, staged in my IDE branch: https://github.com/jnsnow/qemu/commits/ide --js