From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv2HM-0007ik-LH for qemu-devel@nongnu.org; Wed, 20 May 2015 07:35:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yv2HI-0006kS-Bx for qemu-devel@nongnu.org; Wed, 20 May 2015 07:35:16 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:51441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv2HH-0006h1-PU for qemu-devel@nongnu.org; Wed, 20 May 2015 07:35:12 -0400 Message-ID: <555C6FDA.2090607@huawei.com> Date: Wed, 20 May 2015 19:28:26 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1431595182-7552-6-git-send-email-zhaoshenglong@huawei.com> <1432095782-13992-1-git-send-email-zhaoshenglong@huawei.com> <20150520130538.0fe532ce@nial.brq.redhat.com> In-Reply-To: <20150520130538.0fe532ce@nial.brq.redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND PATCH 05/23] hw/acpi/aml-build: Add aml_interrupt() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, alex.bennee@linaro.org, hanjun.guo@linaro.org, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org, shannon.zhao@linaro.org On 2015/5/20 19:05, Igor Mammedov wrote: > On Wed, 20 May 2015 12:23:02 +0800 > Shannon Zhao wrote: > >> > From: Shannon Zhao >> > >> > Add aml_interrupt() for describing device interrupt in resource template. >> > These can be used to generating DSDT table for ACPI on ARM. >> > >> > Signed-off-by: Shannon Zhao >> > Signed-off-by: Shannon Zhao >> > --- >> > hw/acpi/aml-build.c | 22 ++++++++++++++++++++++ >> > include/hw/acpi/aml-build.h | 42 ++++++++++++++++++++++++++++++++++++++++++ >> > 2 files changed, 64 insertions(+) >> > >> > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> > index 805a0ad..5f06367 100644 >> > --- a/hw/acpi/aml-build.c >> > +++ b/hw/acpi/aml-build.c >> > @@ -531,6 +531,28 @@ Aml *aml_memory32_fixed(uint32_t addr, uint32_t size, >> > return var; >> > } >> > >> > +/* >> > + * ACPI 5.0: 6.4.3.6 Extended Interrupt Descriptor >> > + * Type 1, Large Item Name 0x9 >> > + */ >> > +Aml *aml_interrupt(AmlConsumerAndProducer con_and_pro, >> > + AmlLevelAndEdge level_and_edge, >> > + AmlActiveHighAndLow high_and_low, AmlShared shared, >> > + uint32_t irq) >> > +{ >> > + Aml *var = aml_alloc(); >> > + uint8_t irq_flags = con_and_pro | (level_and_edge << 1) >> > + | (high_and_low << 2) | (shared << 3); >> > + >> > + build_append_byte(var->buf, 0x89); /* Extended irq descriptor */ >> > + build_append_byte(var->buf, 6); /* Length, bits[7:0] minimum value = 6 */ >> > + build_append_byte(var->buf, 0); /* Length, bits[15:8] minimum value = 0 */ >> > + build_append_byte(var->buf, irq_flags); /* Interrupt Vector Information. */ >> > + build_append_byte(var->buf, 0x01); /* Interrupt table length = 1 */ >> > + build_append_4bytes(var->buf, irq); /* Interrupt Number */ > Just looking at the patch I have no idea what above line does; > > using 4 build_append_byte() is much clearer and matches the spec 1:1 > when comparing. > I feel awkward and have no word to convince you. If you insist on this, I'll go back to 4 build_append_byte(). -- Shannon