From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv2oo-0004aq-JQ for qemu-devel@nongnu.org; Wed, 20 May 2015 08:09:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yv2ol-0003rN-Bg for qemu-devel@nongnu.org; Wed, 20 May 2015 08:09:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv2ol-0003rE-4r for qemu-devel@nongnu.org; Wed, 20 May 2015 08:09:47 -0400 Message-ID: <555C7985.10703@redhat.com> Date: Wed, 20 May 2015 14:09:41 +0200 From: Michal Privoznik MIME-Version: 1.0 References: <555C52C9.3060602@redhat.com> In-Reply-To: <555C52C9.3060602@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] SMBIOS: Allow users to chose base board type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: rth@twiddle.net On 20.05.2015 11:24, Paolo Bonzini wrote: > > > On 20/05/2015 11:15, Michal Privoznik wrote: >> So far we only mistakenly claimed support for selecting base >> board type. This patch finally implements it. There's an enum in >> SMBIOS specification that lays out all the possible values. >> Therefore, the type is taken as an integer of the corresponding >> string value. >> >> Signed-off-by: Michal Privoznik > > The possible values are: > > 01h Unknown > 02h Other > 03h Server Blade > 04h Connectivity Switch > 05h System Management Module > 06h Processor Module > 07h I/O Module > 08h Memory Module > 09h Daughter board > 0Ah Motherboard (includes processor, memory, and I/O) > 0Bh Processor/Memory Module > 0Ch Processor/IO Module > 0Dh Interconnect Board > > What is the usecase? I've got this bug on me: https://bugzilla.redhat.com/show_bug.cgi?id=1220527 It's request to implement Type 2 in libvirt. However, while implementing that, I found out not all fields are supported in qemu. So I've posted a patch. Michal