From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv4nt-00014t-FJ for qemu-devel@nongnu.org; Wed, 20 May 2015 10:17:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yv4no-0003ap-WF for qemu-devel@nongnu.org; Wed, 20 May 2015 10:17:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv4no-0003ac-R5 for qemu-devel@nongnu.org; Wed, 20 May 2015 10:16:56 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 21662C1F05 for ; Wed, 20 May 2015 14:16:56 +0000 (UTC) Message-ID: <555C9757.5000004@redhat.com> Date: Wed, 20 May 2015 10:16:55 -0400 From: Cole Robinson MIME-Version: 1.0 References: <1432128931-12787-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1432128931-12787-1-git-send-email-mreitz@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] gtk: Replace gdk_cursor_new() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Gerd Hoffmann On 05/20/2015 09:35 AM, Max Reitz wrote: > gdk_cursor_new() has been deprecated in GTK 3.16, it is recommended to > use gdk_cursor_new_for_display() instead, so do that. > > Signed-off-by: Max Reitz > --- > ui/gtk.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/ui/gtk.c b/ui/gtk.c > index c58028f..b9abee1 100644 > --- a/ui/gtk.c > +++ b/ui/gtk.c > @@ -1875,6 +1875,7 @@ void gtk_display_init(DisplayState *ds, bool full_screen, bool grab_on_hover) > { > GtkDisplayState *s = g_malloc0(sizeof(*s)); > char *filename; > + GdkDisplay *window_display; > > gtk_init(NULL, NULL); > > @@ -1893,7 +1894,9 @@ void gtk_display_init(DisplayState *ds, bool full_screen, bool grab_on_hover) > bindtextdomain("qemu", CONFIG_QEMU_LOCALEDIR); > textdomain("qemu"); > > - s->null_cursor = gdk_cursor_new(GDK_BLANK_CURSOR); > + window_display = gtk_widget_get_display(s->window); > + s->null_cursor = gdk_cursor_new_for_display(window_display, > + GDK_BLANK_CURSOR); > > s->mouse_mode_notifier.notify = gd_mouse_mode_change; > qemu_add_mouse_mode_change_notifier(&s->mouse_mode_notifier); > Docs say gdk_cursor_new_for_display is around since gtk 2.2, so looks fine to use unconditionally Reviewed-by: Cole Robinson - Cole