From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv5dx-0005lb-30 for qemu-devel@nongnu.org; Wed, 20 May 2015 11:10:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yv5ds-0006zE-Eu for qemu-devel@nongnu.org; Wed, 20 May 2015 11:10:49 -0400 Received: from mail-qk0-x229.google.com ([2607:f8b0:400d:c09::229]:35388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv5dr-0006yO-9n for qemu-devel@nongnu.org; Wed, 20 May 2015 11:10:43 -0400 Received: by qkdn188 with SMTP id n188so28831012qkd.2 for ; Wed, 20 May 2015 08:10:43 -0700 (PDT) Sender: Richard Henderson Message-ID: <555CA3EE.3020809@twiddle.net> Date: Wed, 20 May 2015 08:10:38 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1432067391-19834-1-git-send-email-rth@twiddle.net> <20150520115838-mutt-send-email-mst@redhat.com> In-Reply-To: <20150520115838-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On 05/20/2015 02:59 AM, Michael S. Tsirkin wrote: > On Tue, May 19, 2015 at 01:29:51PM -0700, Richard Henderson wrote: >> And do not issue an error_report in that case. >> >> Signed-off-by: Richard Henderson >> --- >> hw/virtio/virtio-pci.c | 15 ++++++++++----- >> 1 file changed, 10 insertions(+), 5 deletions(-) >> -- >> >> This seems to be about the only sane way to test the value of >> msi_supported from here. Thoughts? >> >> >> r~ > > Can you please include the qemu command-line that triggers the error > in the commit log? $ ../run/bin/qemu-system-alpha -drive file=foo.img,if=virtio,format=raw qemu-system-alpha: -drive file=foo.img,if=virtio,format=raw: unable to init msix vectors to 2 r~