From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv6OM-00009i-RP for qemu-devel@nongnu.org; Wed, 20 May 2015 11:58:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yv6OJ-0004iM-Mr for qemu-devel@nongnu.org; Wed, 20 May 2015 11:58:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv6OJ-0004iC-FC for qemu-devel@nongnu.org; Wed, 20 May 2015 11:58:43 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4KFwgcw015190 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 20 May 2015 11:58:42 -0400 Message-ID: <555CAF31.9030507@redhat.com> Date: Wed, 20 May 2015 09:58:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432136124-24572-1-git-send-email-quintela@redhat.com> <1432136124-24572-2-git-send-email-quintela@redhat.com> In-Reply-To: <1432136124-24572-2-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GH20U3fWU4tImfLvo7fpHdmrRLuhegFUv" Subject: Re: [Qemu-devel] [PATCH 1/3] migration: Remove duplicated assignement of SETUP status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, jdenemar@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GH20U3fWU4tImfLvo7fpHdmrRLuhegFUv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/20/2015 09:35 AM, Juan Quintela wrote: > We assign the MIGRATION_STATUS_SETUP status in two places. Just in > sucession. Just remove the second one. s/sucession/succession/ Where's the second place? Not in migrate_fd_connect... okay, migrate_init() does the same thing, and I guess you're arguing that it was always called either just before or just after migrate_fd_connect can be called. But mentioning it in the commit message would help. >=20 > Signed-off-by: Juan Quintela > --- > migration/migration.c | 3 --- > 1 file changed, 3 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GH20U3fWU4tImfLvo7fpHdmrRLuhegFUv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVXK8xAAoJEKeha0olJ0NqQSUH/iBxhkeS0If3YdzcP9IP4vxE MmK4GtFtHnImde53KCcTdneyzTShF0l2z9xFLMWTlSJZTyvV2WgOxuA28nb2SMmy yBlW0lptkP0GxrqrVOifhLu8xaJn/nEhMghY2vAC2p4iLQGeCHjuGoSiEETRf9n7 CPMMUVlkZGmZBwxf0Z7N9wP0l3L/TaJY7WYtYRg9AR4pmclawdseo1RebTf09bO7 n7cWB5RD0tKZV+sS/NvHdNAt2WdDoAX3jgrTgdTT3zSZoZOY6FlLUJJY8n2FO91v q3f/qV8zX7MiLKXFB9TqFzAO3ovQxAGMKs94E5y8rBkUVG/cnUeEfX5pBaHl6ho= =jlaW -----END PGP SIGNATURE----- --GH20U3fWU4tImfLvo7fpHdmrRLuhegFUv--