From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv6TV-0007Jm-R5 for qemu-devel@nongnu.org; Wed, 20 May 2015 12:04:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yv6TR-0007Q7-T8 for qemu-devel@nongnu.org; Wed, 20 May 2015 12:04:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv6TR-0007PY-NQ for qemu-devel@nongnu.org; Wed, 20 May 2015 12:04:01 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id CBD698E78A for ; Wed, 20 May 2015 16:04:00 +0000 (UTC) Message-ID: <555CB06F.3090804@redhat.com> Date: Wed, 20 May 2015 12:03:59 -0400 From: John Snow MIME-Version: 1.0 References: <1432136124-24572-1-git-send-email-quintela@redhat.com> <1432136124-24572-2-git-send-email-quintela@redhat.com> <555CAF31.9030507@redhat.com> In-Reply-To: <555CAF31.9030507@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] migration: Remove duplicated assignement of SETUP status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Juan Quintela , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, jdenemar@redhat.com On 05/20/2015 11:58 AM, Eric Blake wrote: > On 05/20/2015 09:35 AM, Juan Quintela wrote: >> We assign the MIGRATION_STATUS_SETUP status in two places. Just >> in sucession. Just remove the second one. > > s/sucession/succession/ > Also s/assignement/assignment/ in the subject. > Where's the second place? Not in migrate_fd_connect... > > okay, migrate_init() does the same thing, and I guess you're > arguing that it was always called either just before or just after > migrate_fd_connect can be called. But mentioning it in the commit > message would help. > >> >> Signed-off-by: Juan Quintela --- >> migration/migration.c | 3 --- 1 file changed, 3 deletions(-) >> > > Reviewed-by: Eric Blake >