From: Richard Henderson <rth@twiddle.net>
To: Yongbok Kim <yongbok.kim@imgtec.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, leon.alrae@imgtec.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v4 3/3] target-mips: Misaligned memory accesses for MSA
Date: Thu, 21 May 2015 09:16:40 -0700 [thread overview]
Message-ID: <555E04E8.9040806@twiddle.net> (raw)
In-Reply-To: <555DA9A9.7030407@imgtec.com>
On 05/21/2015 02:47 AM, Yongbok Kim wrote:
> On 20/05/2015 18:25, Richard Henderson wrote:
>
>>
>>> + int i; \
>>> + for (i = 0; i < DF_ELEMENTS(DF); i++) { \
>>> + wx.TYPE[i] = LD_INSN(env, addr + (i << DF), ##__VA_ARGS__); \
>>
>> Why the varargs? They're the same all the time.
>
> No, they aren't. we still need to support linux user mode which don't have
> any extra argument.
>
> MSA_LD_DF(DF_BYTE, b, helper_ret_ldub_mmu, \
> make_memop_idx(MO_UNALN, cpu_mmu_index(env)), GETRA())
>
> VS.
>
> MSA_LD_DF(DF_BYTE, b, cpu_ldub_data)
Ah, I'd missed that. Thanks,
r~
prev parent reply other threads:[~2015-05-21 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:12 [Qemu-devel] [PATCH v4 0/3] target-mips: Add support for misaligned accesses Yongbok Kim
2015-05-20 15:12 ` [Qemu-devel] [PATCH v4 1/3] target-mips: Misaligned memory accesses for R6 Yongbok Kim
2015-05-20 17:09 ` Richard Henderson
2015-05-21 9:47 ` Yongbok Kim
2015-05-21 16:15 ` Richard Henderson
2015-05-20 15:12 ` [Qemu-devel] [PATCH v4 2/3] softmmu: Add probe_write() Yongbok Kim
2015-05-20 17:10 ` Richard Henderson
2015-05-20 15:12 ` [Qemu-devel] [PATCH v4 3/3] target-mips: Misaligned memory accesses for MSA Yongbok Kim
2015-05-20 17:25 ` Richard Henderson
2015-05-21 9:47 ` Yongbok Kim
2015-05-21 16:16 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555E04E8.9040806@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=leon.alrae@imgtec.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yongbok.kim@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).