From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvUB1-00009i-Ce for qemu-devel@nongnu.org; Thu, 21 May 2015 13:22:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvUAw-0002l6-HU for qemu-devel@nongnu.org; Thu, 21 May 2015 13:22:35 -0400 Received: from mail-qg0-x22d.google.com ([2607:f8b0:400d:c04::22d]:35741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvUAw-0002kx-DZ for qemu-devel@nongnu.org; Thu, 21 May 2015 13:22:30 -0400 Received: by qgew3 with SMTP id w3so44489311qge.2 for ; Thu, 21 May 2015 10:22:30 -0700 (PDT) Sender: Richard Henderson Message-ID: <555E1452.6000401@twiddle.net> Date: Thu, 21 May 2015 10:22:26 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1431510311-13355-1-git-send-email-kbastian@mail.uni-paderborn.de> <1431510311-13355-5-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1431510311-13355-5-git-send-email-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/10] target-tricore: add CMPSWP instructions of the v1.6.1 ISA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , qemu-devel@nongnu.org On 05/13/2015 02:45 AM, Bastian Koppelmann wrote: > Those instruction were introduced in the new Aurix platform. > > Signed-off-by: Bastian Koppelmann I can't really review this, because I can only find the v1.6 isa. That said, the code for gen_cmpswap looks plausible, so... Reviewed-by: Richard Henderson r~