From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53145)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YvUHH-00051J-OH
	for qemu-devel@nongnu.org; Thu, 21 May 2015 13:29:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YvUHC-00060V-OH
	for qemu-devel@nongnu.org; Thu, 21 May 2015 13:29:03 -0400
Received: from mail-qg0-x235.google.com ([2607:f8b0:400d:c04::235]:34502)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YvUHC-00060J-JG
	for qemu-devel@nongnu.org; Thu, 21 May 2015 13:28:58 -0400
Received: by qgez61 with SMTP id z61so40824707qge.1
	for <qemu-devel@nongnu.org>; Thu, 21 May 2015 10:28:58 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <555E15D6.7060905@twiddle.net>
Date: Thu, 21 May 2015 10:28:54 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1431510311-13355-1-git-send-email-kbastian@mail.uni-paderborn.de>
	<1431510311-13355-9-git-send-email-kbastian@mail.uni-paderborn.de>
In-Reply-To: <1431510311-13355-9-git-send-email-kbastian@mail.uni-paderborn.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 08/10] target-tricore: add FCALL
 instructions of the v1.6 ISA
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, qemu-devel@nongnu.org

On 05/13/2015 02:45 AM, Bastian Koppelmann wrote:
> +static void gen_fcall_save_ctx(DisasContext *ctx)
> +{
> +    tcg_gen_addi_tl(cpu_gpr_a[10], cpu_gpr_a[10], -4);
> +    tcg_gen_qemu_st_tl(cpu_gpr_a[11], cpu_gpr_a[10], ctx->mem_idx, MO_LESL);
> +    tcg_gen_movi_tl(cpu_gpr_a[11], ctx->next_pc);
> +}

Does a[10] really get updated if the store traps?


r~