From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvVkm-0005Lt-4Z for qemu-devel@nongnu.org; Thu, 21 May 2015 15:03:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvVkh-0003vv-Vg for qemu-devel@nongnu.org; Thu, 21 May 2015 15:03:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvVkh-0003vb-Nz for qemu-devel@nongnu.org; Thu, 21 May 2015 15:03:31 -0400 Message-ID: <555E2BFE.8040805@redhat.com> Date: Thu, 21 May 2015 13:03:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <20150124121851.4278.77991.stgit@s440> <1432218012-31328-1-git-send-email-changchun.ouyang@intel.com> In-Reply-To: <1432218012-31328-1-git-send-email-changchun.ouyang@intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="utFVjshoAOoFn5IvQBRd0nIahq31EoTif" Subject: Re: [Qemu-devel] [PATCH v3] vhost-user: add multi queue support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ouyang Changchun , qemu-devel@nongnu.org, mst@redhat.com Cc: luke@snabb.co, snabb-devel@googlegroups.com, thomas.long@intel.com, n.nikolaev@virtualopensystems.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --utFVjshoAOoFn5IvQBRd0nIahq31EoTif Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/21/2015 08:20 AM, Ouyang Changchun wrote: > From: Changchun Ouyang >=20 It's better to post a v3 patch as a new top-level thread, rather than in-reply-to an existing thread. > Based on patch by Nikolay Nikolaev: > Vhost-user will implement the multi queue support in a similar way > to what vhost already has - a separate thread for each queue. > To enable the multi queue funcionality - a new command line parameter s/funcionality/functionality/ > "queues" is introduced for the vhost-user netdev. >=20 > Signed-off-by: Nikolay Nikolaev > Signed-off-by: Changchun Ouyang > --- > Changes since v2: > - fix vq index issue for set_vring_call > When it is the case of VHOST_SET_VRING_CALL, The vq_index is not ini= tialized before it is used, > thus it could be a random value. The random value lead to crash in v= host after passing down > to vhost, as vhost use this random value to index an array index. > - fix the typo in the doc and description > - address vq index for reset_owner > +++ b/qapi-schema.json > @@ -2444,12 +2444,16 @@ > # > # @vhostforce: #optional vhost on for non-MSIX virtio guests (default:= false). > # > +# @queues: #optional number of queues to be created for multiqueue vho= st-user (default: 1). Long line; please wrap to fit under 80 columns. > +# (Since 2.4) > +# > # Since 2.1 > ## > { 'struct': 'NetdevVhostUserOptions', > 'data': { > 'chardev': 'str', > - '*vhostforce': 'bool' } } > + '*vhostforce': 'bool', > + '*queues': 'uint32' } } --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --utFVjshoAOoFn5IvQBRd0nIahq31EoTif Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVXiv+AAoJEKeha0olJ0NqxRAH/jtoAQeGRdma9OxCgnkxe95S v74miUkigFcMntEglgMJhl3SxLudGE5lp021OiEzM/Fx5EX/iCWhgUnGVrD1vfHT P0yoYpFrdBc/zQcmy0eGqZ001kVQPqA7CgMUMqqt0OUcNZeA0hRKiWX7kgVI3IxS GLlSsHwqwF5WctOtslT0LwwXFICsML7sGwy1tbBRnHRsBdIodrfQcVoqhnIq6SQo s1Ms9LTt5kX+SzNwNIr1wjVp1gAB9Ofsn4pbesQhkBEyqfKMc5ELUhZi3C5ee3TC sEfOYLHA36BvXRHgU4yffsQy12qJH0bQ0ME4Hq2WGnQO/iJFLEGDGXtIf2ETJ3k= =lwbg -----END PGP SIGNATURE----- --utFVjshoAOoFn5IvQBRd0nIahq31EoTif--