From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44015)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1Yvi0R-0006Qb-71
	for qemu-devel@nongnu.org; Fri, 22 May 2015 04:08:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1Yvi0N-0007gk-PD
	for qemu-devel@nongnu.org; Fri, 22 May 2015 04:08:35 -0400
Received: from mail.uni-paderborn.de ([131.234.142.9]:58718)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1Yvi0N-0007gX-I7
	for qemu-devel@nongnu.org; Fri, 22 May 2015 04:08:31 -0400
Message-ID: <555EE3FC.50907@mail.uni-paderborn.de>
Date: Fri, 22 May 2015 10:08:28 +0200
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
MIME-Version: 1.0
References: <1431510311-13355-1-git-send-email-kbastian@mail.uni-paderborn.de>
	<1431510311-13355-9-git-send-email-kbastian@mail.uni-paderborn.de>
	<555E15D6.7060905@twiddle.net>
In-Reply-To: <555E15D6.7060905@twiddle.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 08/10] target-tricore: add FCALL
 instructions of the v1.6 ISA
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org



On 05/21/2015 07:28 PM, Richard Henderson wrote:
> On 05/13/2015 02:45 AM, Bastian Koppelmann wrote:
>> +static void gen_fcall_save_ctx(DisasContext *ctx)
>> +{
>> +    tcg_gen_addi_tl(cpu_gpr_a[10], cpu_gpr_a[10], -4);
>> +    tcg_gen_qemu_st_tl(cpu_gpr_a[11], cpu_gpr_a[10], ctx->mem_idx, MO_LESL);
>> +    tcg_gen_movi_tl(cpu_gpr_a[11], ctx->next_pc);
>> +}
> Does a[10] really get updated if the store traps?
Good catch! It does not and a tmp is required.

Cheers,
Bastian