From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvnX7-0001cU-DD for qemu-devel@nongnu.org; Fri, 22 May 2015 10:02:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvnX1-0006BI-DP for qemu-devel@nongnu.org; Fri, 22 May 2015 10:02:41 -0400 Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]:35654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvnX1-0006Ay-5D for qemu-devel@nongnu.org; Fri, 22 May 2015 10:02:35 -0400 Received: by pacwv17 with SMTP id wv17so20426792pac.2 for ; Fri, 22 May 2015 07:02:34 -0700 (PDT) Sender: Richard Henderson Message-ID: <555F36F5.2080400@twiddle.net> Date: Fri, 22 May 2015 07:02:29 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1432229986-772-1-git-send-email-rth@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v2 00/18] target-alpha fpu improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On 05/22/2015 04:32 AM, Peter Maydell wrote: > On 22 May 2015 at 11:22, Peter Maydell wrote: >> On 22 May 2015 at 11:00, Peter Maydell wrote: >>> On 21 May 2015 at 18:39, Richard Henderson wrote: >>>> for you to fetch changes up to 32ad48abd74a997220b841e4e913edeb267aa362: >>>> >>>> target-alpha: Add vector implementation for CMPBGE (2015-05-21 10:34:18 -0700) >>> >>> Applied, thanks. >> >> Except I failed to notice a test failure from one of my builds >> before pushing: >> >> target-alpha/int_helper.c: In function 'helper_cmpbge': >> target-alpha/int_helper.c:77: error: invalid operands to binary >= >> target-alpha/int_helper.c:79: error: subscripted value is neither >> array nor pointer >> >> That's in the Centos5 build, which is >> gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55) >> >> Any suggestions? >> >> I do note that this build target is basically obsolete anyway, because >> we're about to move to requiring glib 2.22, at which point Centos5 is >> officially Too Old. So maybe we just say "yeah, you need a newer gcc" ? > > Hmm. This fails on some of the travis builds too, with slightly > different warnings: > > gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3 > target-alpha/int_helper.c:77:24: error: invalid operands to binary >= > (have '__vector(16) unsigned char' and '__vector(16) unsigned char') > > I think the best thing to do for the moment is to revert commit > 32ad48abd74a9 so we can get trunk building again, so I'm going to > do that. Wow, I would have thought 4.6 would have been new enough. Sorry for the headache. Yes, a revert is probably best until I can figure out what versions do what. r~