From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvqja-0007z2-VV for qemu-devel@nongnu.org; Fri, 22 May 2015 13:27:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvqjW-0001XE-Rb for qemu-devel@nongnu.org; Fri, 22 May 2015 13:27:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvqjW-0001X6-La for qemu-devel@nongnu.org; Fri, 22 May 2015 13:27:42 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 334642BB38D for ; Fri, 22 May 2015 17:27:42 +0000 (UTC) Message-ID: <555F670D.5010307@redhat.com> Date: Fri, 22 May 2015 13:27:41 -0400 From: John Snow MIME-Version: 1.0 References: <1431460381-8530-1-git-send-email-jsnow@redhat.com> <55525D43.6060402@redhat.com> <87y4kht2oc.fsf@blackfin.pond.sub.org> In-Reply-To: <87y4kht2oc.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qapi: add dirty bitmap status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Eric Blake Cc: qemu-devel@nongnu.org On 05/22/2015 04:52 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 05/12/2015 01:53 PM, John Snow wrote: >>> Bitmaps can be in a handful of different states with potentially >>> more to come as we tool around with migration and persistence patches. >>> >>> Instead of having a bunch of boolean fields, it was suggested that we >>> just have an enum status field that will help expose the reason to >>> management APIs why certain bitmaps may be unavailable for various >>> commands >>> >>> (e.g. busy in another operation, busy being migrated, etc.) >> >> Might be worth mentioning that this is an API change, but safe because >> the old API is unreleased (and therefore, this patch MUST go in the 2.4 >> time frame, if at all). >> >>> >>> Suggested-by: Eric Blake >>> Signed-off-by: John Snow >>> --- >>> block.c | 13 ++++++++++++- >>> include/block/block.h | 1 + >>> qapi/block-core.json | 23 +++++++++++++++++++++-- >>> 3 files changed, 34 insertions(+), 3 deletions(-) >>> >> >> Reviewed-by: Eric Blake > > Patch does two things: > > 1. Convert status from bool frozen to enum. > 2. Add new status 'disabled'. > > I would've done this separately, but it's no big deal. But I think we > should spell it out in the commit message. > > What about: > > qapi: add dirty bitmap status > > Bitmaps can be in a handful of different states with potentially > more to come as we tool around with migration and persistence patches. > > Management applications may need to know why certain bitmaps are > unavailable for various commands, e.g. busy in another operation, > busy being migrated, etc. > > Right now, all we offer is BlockDirtyInfo's boolean member 'frozen'. > Instead of adding more booleans, replace it by an enumeration member > 'status' with values 'active' and 'frozen'. Then add new value > 'disabled'. > > Incompatible change. Fine because the changed part hasn't been > released so far. > > Suggested-by: Eric Blake > Signed-off-by: John Snow > Reviewed-by: Eric Blake > [Commit message tweaked] > Signed-off-by: Markus Armbruster > This is OK by me, Markus. I'll assume that you are OK with or have already made these changes locally, so I won't resend. Thank you, --John