From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvsq6-0000P6-Ow for qemu-devel@nongnu.org; Fri, 22 May 2015 15:42:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yvsq2-0001Qu-CN for qemu-devel@nongnu.org; Fri, 22 May 2015 15:42:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvsq2-0001QB-4u for qemu-devel@nongnu.org; Fri, 22 May 2015 15:42:34 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4MJgW6h032473 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 22 May 2015 15:42:33 -0400 Message-ID: <555F86A7.5040401@redhat.com> Date: Fri, 22 May 2015 13:42:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432322539-23719-1-git-send-email-thuth@redhat.com> In-Reply-To: <1432322539-23719-1-git-send-email-thuth@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wqWoPRq5J8qW6Os4qND8rjXdF9wC0BKsw" Subject: Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too, List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org, Stefan Hajnoczi , Jason Wang Cc: Markus Armbruster , "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wqWoPRq5J8qW6Os4qND8rjXdF9wC0BKsw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/22/2015 01:22 PM, Thomas Huth wrote: > So far, it is not possible to use the network dump interface > with the "-netdev" option yet, it only works with the legacy > "-net" option. To be able to use it with "-netdev", too, this > patch now enables the "vlan" packet distribution for the > "-netdev" option, too, so that you can now dump network packets > like this: >=20 > qemu... -device e1000,netdev=3Dmyhub -netdev hubport,hubid=3D1,id=3Dmyh= ub \ > -netdev user,id=3Dn1,vlan=3D1,tftp=3D/tmp/tftp,bootfile=3DzImag= e \ > -netdev dump,id=3Dn2,vlan=3D1,file=3D/tmp/dump.dat >=20 > Signed-off-by: Thomas Huth > --- > +++ b/qapi-schema.json > @@ -2512,6 +2512,7 @@ > { 'struct': 'Netdev', > 'data': { > 'id': 'str', > + '*vlan': 'int32', > 'opts': 'NetClientOptions' } } Needs a documentation blurb for the new parameter, including '#optional' and '(since 2.4)' markings. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wqWoPRq5J8qW6Os4qND8rjXdF9wC0BKsw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVX4anAAoJEKeha0olJ0NqCzEH/1+3IcCS2m+Zq7e6CfpLmCce QP66tfIOef9gJqGPhY3nsEsC7KprIh8wThLe3Y75OfmCVB2YBjs0dPnvwZuZ2bfK A63W/yhZeQVArPGRKW7kgWQGa8EcAiJRRQrRYVTVL+b4hz2yw7AVqga5M+cl00h2 1cqZOMoKBePBNe/HraM4qMB0jDsJe3IuaCGiASKqu+AuOT+Ers/nH7OTkXhweZKH Zqr8zfeZn6rwAbDkHqNsFf9K/GVZatzo9c4zinD4R7yEQ5iR/eiqKbdqKOIdgFaL 3brGsbrzILNW/C2qsvb4zGamwX0X1f9NJUNT71D4JrfpPOBDrG1DuNVfGiv4ixg= =U9tG -----END PGP SIGNATURE----- --wqWoPRq5J8qW6Os4qND8rjXdF9wC0BKsw--