From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvtbF-00022P-E6 for qemu-devel@nongnu.org; Fri, 22 May 2015 16:31:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvtbC-0007EJ-2C for qemu-devel@nongnu.org; Fri, 22 May 2015 16:31:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvtbB-0007E4-Qm for qemu-devel@nongnu.org; Fri, 22 May 2015 16:31:18 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4MKVGKi015870 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 22 May 2015 16:31:17 -0400 Message-ID: <555F9213.1050906@redhat.com> Date: Fri, 22 May 2015 14:31:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432325832-12887-1-git-send-email-jsnow@redhat.com> <1432325832-12887-2-git-send-email-jsnow@redhat.com> In-Reply-To: <1432325832-12887-2-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="amgKWt9OXDecVubjBubEd1JIkakeQ16TT" Subject: Re: [Qemu-devel] [PATCH 1/4] iotests: fix exclusion option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --amgKWt9OXDecVubjBubEd1JIkakeQ16TT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/22/2015 02:17 PM, John Snow wrote: > If you are running out-of-tree, the -x option to exclude > a certain iotest is broken. >=20 > Replace porcelain usage of ls with a sturdier grep command. >=20 > Signed-off-by: John Snow > --- > tests/qemu-iotests/common | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common > index 1e556bb..c4d0742 100644 > --- a/tests/qemu-iotests/common > +++ b/tests/qemu-iotests/common > @@ -82,7 +82,8 @@ s/ .*//p > elif $xgroup > then > # arg after -x > - [ ! -s $tmp.list ] && ls [0-9][0-9][0-9] [0-9][0-9][0-9][0-9] = >$tmp.list 2>/dev/null > + # Populate $tmp.list with all tests > + grep -oh -E "^([0-9]{3,})" "${source_iotests}/group" > $tmp.li= st 2>/dev/null 'grep -oh' is a GNU-ism; is it going to cause grief on BSD platforms? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --amgKWt9OXDecVubjBubEd1JIkakeQ16TT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVX5ITAAoJEKeha0olJ0NqejAH/0YaxagENS7bzqfYu4zA2lnY ZEl2leblP77PW9lmatGa5YiTQ89obIB3MiC1GU4VsgTDqBkSntPVrIWvGNgJhIu+ lIjfAxhX+ZIQo4UhntJECsjp3GrNZlIKfiH9z0taCGBLXMHqJ2N37amUfxAYyXLq 2mX/1THrzVVrCQB3FOnR7m3ufO6EZa+7+HFEq6BMnUyE8ttcZmE2ruXqcRCyAiln 4Kw6GlAJJmqyMjjUhbwSlGGUsNpKZzFp3ngrW6ToW8/wPN7JpwHEklUGiQW4K/mk uY53hD/QOz+N4T/cWIx4zLxZj+hhd7GPcOlnJ6FwM9Hf8gF+34567FAdZiTlYVs= =0b5g -----END PGP SIGNATURE----- --amgKWt9OXDecVubjBubEd1JIkakeQ16TT--