From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvuNZ-0007rY-PM for qemu-devel@nongnu.org; Fri, 22 May 2015 17:21:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvuNX-0008Id-0r for qemu-devel@nongnu.org; Fri, 22 May 2015 17:21:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvuNW-0008IX-Ry for qemu-devel@nongnu.org; Fri, 22 May 2015 17:21:14 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 8EFF49176D for ; Fri, 22 May 2015 21:21:14 +0000 (UTC) Message-ID: <555F9DC9.9090802@redhat.com> Date: Fri, 22 May 2015 15:21:13 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-4-git-send-email-armbru@redhat.com> In-Reply-To: <1432294585-5984-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Mq8U3lsW1iT4XNhOWQfQ8kMrP6Idt8EEl" Subject: Re: [Qemu-devel] [PATCH 03/20] monitor: Improve and document client_migrate_info protocol error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Mq8U3lsW1iT4XNhOWQfQ8kMrP6Idt8EEl Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Protocol must be spice, vnc isn't implemented. Fix up documentation. >=20 > Attempts to use vnc or any other unknown protocol yield the misleading > error message "Invalid parameter 'protocol'". Improve it to > "Parameter 'protocol' expects spice". >=20 > Signed-off-by: Markus Armbruster > --- > hmp-commands.hx | 1 + > monitor.c | 2 +- > qmp-commands.hx | 3 ++- > 3 files changed, 4 insertions(+), 2 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Mq8U3lsW1iT4XNhOWQfQ8kMrP6Idt8EEl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVX53JAAoJEKeha0olJ0NqYbUH/jyN/WBpUpxH/g+ho4VvBt/E 61XaJ8IrZsRma5CsP8s+lkD0/HiHHFsNRqCfrxU0LFlwJ78+quMTx7xb9sGQOccc pK/FaQHc1yNoxSkbkrae+skhXKGc4W4KlzbRBQ8+ri70AXet5IBg48TLdis+XEhs kifmQyKMjvjvqpgkoI5+CDuLddpPoM89WSY6yHNI61UK/TMGqoP/2kluYNBqtzCY 0yZyLY21a5lup8nQQLvs/QXZxImE0Mi+p2P9/XxnSfbICckqPVwlh/fzUvls0nE/ fKq/A2OolkIUkXYBY/k0i7dnIU8Z/hO8e57E2W/YJqjneJI5gfeYi21UWhQNlBE= =wFjb -----END PGP SIGNATURE----- --Mq8U3lsW1iT4XNhOWQfQ8kMrP6Idt8EEl--