From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvunN-0002eG-6J for qemu-devel@nongnu.org; Fri, 22 May 2015 17:47:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvunK-0001tQ-Pv for qemu-devel@nongnu.org; Fri, 22 May 2015 17:47:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvunK-0001tD-Kj for qemu-devel@nongnu.org; Fri, 22 May 2015 17:47:54 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 2E9AB2B6485 for ; Fri, 22 May 2015 21:47:54 +0000 (UTC) Message-ID: <555FA409.2080401@redhat.com> Date: Fri, 22 May 2015 15:47:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-6-git-send-email-armbru@redhat.com> In-Reply-To: <1432294585-5984-6-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7PFs4GqmBa4Tj09VriDBnMfEGxt5EIbSL" Subject: Re: [Qemu-devel] [PATCH 05/20] monitor: Use traditional command interface for HMP drive_del List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7PFs4GqmBa4Tj09VriDBnMfEGxt5EIbSL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/22/2015 05:36 AM, Markus Armbruster wrote: > All QMP commands use the "new" handler interface (mhandler.cmd_new). > Most HMP commands still use the traditional interface (mhandler.cmd), > but a few use the "new" one. Complicates handle_user_command() for no > gain, so I'm converting these to the traditional interface. >=20 > For drive_del, that's easy: hmp_drive_del() sheds its unused last > parameter, and its return value, which the caller ignored anyway. >=20 > Signed-off-by: Markus Armbruster > --- > blockdev.c | 9 ++++----- > hmp-commands.hx | 3 +-- > include/sysemu/blockdev.h | 2 +- > 3 files changed, 6 insertions(+), 8 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7PFs4GqmBa4Tj09VriDBnMfEGxt5EIbSL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVX6QJAAoJEKeha0olJ0NqZC4H/R8Ai2hJEutdSJdop8SUG2g5 c4cr+MsuqLey3WP+Pp3EV/o3wCTFOOCwrMn7bX5dXsccoDAhwaUpvAUilzCHsLR1 NQvUhmcxxsczxlGOJrzCFkunCWz6lm2FZ6bndiyE44AKSkZ//UXQ2i07Xg9j0sZ2 f2cqYWzljn7y4dlZyBSK4CWtM8ZQtBPh1maay+xwk56hRUBHSPn/n9US+pnLp0WC Vnz3cbbA2XauAAoyAI35Ck/iW4TwK36cPr5nJWcD/XZ0uYZN9xzQAdpa3OEjQ2WH zwCqSj24vRGiyLVzmRYoOtgv5XdR7+vTGA2Hn+2ZVUnwQKu9fqR6/afH8oj06kc= =uMhk -----END PGP SIGNATURE----- --7PFs4GqmBa4Tj09VriDBnMfEGxt5EIbSL--