From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvuvN-0000zA-Pq for qemu-devel@nongnu.org; Fri, 22 May 2015 17:56:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvuvK-0004QI-AC for qemu-devel@nongnu.org; Fri, 22 May 2015 17:56:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvuvK-0004Q9-1p for qemu-devel@nongnu.org; Fri, 22 May 2015 17:56:10 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4MLu9xf021723 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 22 May 2015 17:56:09 -0400 Message-ID: <555FA5F8.5030208@redhat.com> Date: Fri, 22 May 2015 15:56:08 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-7-git-send-email-armbru@redhat.com> In-Reply-To: <1432294585-5984-7-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wSmFO9FO7LHM11AfhX5kGpoFUmSLpXeFr" Subject: Re: [Qemu-devel] [PATCH 06/20] monitor: Use traditional command interface for HMP device_add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wSmFO9FO7LHM11AfhX5kGpoFUmSLpXeFr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/22/2015 05:36 AM, Markus Armbruster wrote: > All QMP commands use the "new" handler interface (mhandler.cmd_new). > Most HMP commands still use the traditional interface (mhandler.cmd), > but a few use the "new" one. Complicates handle_user_command() for no > gain, so I'm converting these to the traditional interface. >=20 > For device_add, that's easy: just wrap the obvious hmp_device_add() > around do_device_add(). >=20 > monitor_user_noop() is now unused, drop it. >=20 > Signed-off-by: Markus Armbruster > --- > hmp-commands.hx | 3 +-- > hmp.c | 6 ++++++ > hmp.h | 1 + > monitor.c | 2 -- > 4 files changed, 8 insertions(+), 4 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wSmFO9FO7LHM11AfhX5kGpoFUmSLpXeFr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVX6X4AAoJEKeha0olJ0Nq7nsIAIEOqCALEJgSipHuyqJrnjSQ PyzShtRk3jCsKaj55dApId2t8pYWierVZIwZWlRfP/YeKW8pmW0iPkXfoJYI+to8 PMs8wr1hYvrPrzuVNHahYXEsCoRTkJGw8wIX/eeHYRLcLwmw4qQWCjmgIDzSarUO lG+dP9MZAZJgyAbaOz7sNDArmD33uRggvbxhMwWedxil092TZzLRc0vq5ZBauWxW Cwg5gfoACssn51EL/TnFXUIgeagegCEUGW4tmZUbuY1dACvV9XkSXbZ1c38INPT4 KyvvBdLTYWYqyBLr4yuWsehZsJ50CLaFxIjxo4/35/xRRPjOJ5PGjl+Y7CzqF8w= =DRZ8 -----END PGP SIGNATURE----- --wSmFO9FO7LHM11AfhX5kGpoFUmSLpXeFr--