From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvv4c-0003X7-Gg for qemu-devel@nongnu.org; Fri, 22 May 2015 18:05:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yvv4Z-0007cv-B2 for qemu-devel@nongnu.org; Fri, 22 May 2015 18:05:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvv4Z-0007cp-2W for qemu-devel@nongnu.org; Fri, 22 May 2015 18:05:43 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4MM5fE5018924 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 22 May 2015 18:05:42 -0400 Message-ID: <555FA834.2080506@redhat.com> Date: Fri, 22 May 2015 16:05:40 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-8-git-send-email-armbru@redhat.com> In-Reply-To: <1432294585-5984-8-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3CNmNqgicq8OjO6Qpj36KfWA4OuITqip3" Subject: Re: [Qemu-devel] [PATCH 07/20] monitor: Use trad. command interface for HMP pcie_aer_inject_error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3CNmNqgicq8OjO6Qpj36KfWA4OuITqip3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/22/2015 05:36 AM, Markus Armbruster wrote: > All QMP commands use the "new" handler interface (mhandler.cmd_new). > Most HMP commands still use the traditional interface (mhandler.cmd), > but a few use the "new" one. Complicates handle_user_command() for no > gain, so I'm converting these to the traditional interface. >=20 > pcie_aer_inject_error's implementation is split into the > hmp_pcie_aer_inject_error() and pcie_aer_inject_error_print(). The > former is a peculiar crossbreed between HMP and QMP handler. On > success, it works like a QMP handler: store QDict through ret_data > parameter, return 0. Printing the QDict is left to > pcie_aer_inject_error_print(). On failure, it works more like an HMP > handler: print error to monitor, return negative number. >=20 > To convert to the traditional interface, turn > pcie_aer_inject_error_print() into a command handler wrapping around > hmp_pcie_aer_inject_error(). By convention, this command handler > should be called hmp_pcie_aer_inject_error(), so rename the existing > hmp_pcie_aer_inject_error() to do_pcie_aer_inject_error(). >=20 > Signed-off-by: Markus Armbruster > --- > hmp-commands.hx | 3 +-- > hw/pci/pci-stub.c | 14 +------------- > hw/pci/pcie_aer.c | 39 ++++++++++++++++++++++----------------- > include/sysemu/sysemu.h | 4 +--- > 4 files changed, 25 insertions(+), 35 deletions(-) >=20 > + > + devfn =3D (int)qdict_get_int(qdict, "devfn"); Code motion, so the problem is pre-existing, but this cast is unneeded. Up to you if you want to clean it up now. > + monitor_printf(mon, "OK id: %s root bus: %s, bus: %x devfn: %x.%x\= n", > + qdict_get_str(qdict, "id"), > + qdict_get_str(qdict, "root_bus"), > + (int) qdict_get_int(qdict, "bus"), However, this one still is necessary, unless you tweak the format string (if you haven't guessed, I prefer avoiding casts when other mechanisms work equally well). But that's minor; whether or not you clean things up, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3CNmNqgicq8OjO6Qpj36KfWA4OuITqip3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVX6g0AAoJEKeha0olJ0NqcrUH/A9GkjRCPQUcwoiFohIXRjdC EfNbh8BtzD2QU0btz773oillXA6PTzzrRYj5PxyZb4l7kO2yHQ+brgWC7KVQBtgP 7XgnJ2Sz+L/yEk33hUv4qFuJ+mzx/KGLfz7HnLHRjAtG2wYSTMnrf9oL5gYpnUOh swx64G+5Ag3N9bmpvrDkhbYsbuwm9wJHwHz6IlJ/Bg8gPVbvbSMygv/aTOL62Tlo znoUV2iNvGiU3e7OmGloQR6PQW5ySrSTuf2cL5WSIiWE8arN7Ox6u9UVPv20H7fJ kLrw7755sQl2HTGXdCtVydFM3jRX93ucdo8MKID/1XpPCxVzPhql7YBm7x2WHEY= =ec/L -----END PGP SIGNATURE----- --3CNmNqgicq8OjO6Qpj36KfWA4OuITqip3--