From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvvJN-0007vn-Pc for qemu-devel@nongnu.org; Fri, 22 May 2015 18:21:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvvJI-0004Mo-R0 for qemu-devel@nongnu.org; Fri, 22 May 2015 18:21:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvvJI-0004Mk-Lf for qemu-devel@nongnu.org; Fri, 22 May 2015 18:20:56 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 4CE36A0CDF for ; Fri, 22 May 2015 22:20:56 +0000 (UTC) Message-ID: <555FABC7.90701@redhat.com> Date: Fri, 22 May 2015 16:20:55 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-11-git-send-email-armbru@redhat.com> In-Reply-To: <1432294585-5984-11-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Nrsi3jtWRpMC807SeA9MrTIf9s3Iish2f" Subject: Re: [Qemu-devel] [PATCH 10/20] monitor: Propagate errors through qmp_check_input_obj() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Nrsi3jtWRpMC807SeA9MrTIf9s3Iish2f Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > monitor.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) >=20 > @@ -4948,27 +4948,27 @@ static QDict *qmp_check_input_obj(QObject *inpu= t_obj) > } > } else if (!strcmp(arg_name, "id")) { > /* FIXME: check duplicated IDs for async commands */ Is this comment dead, now that you killed async commands? If so, should it be nuked earlier in the series? Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Nrsi3jtWRpMC807SeA9MrTIf9s3Iish2f Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVX6vHAAoJEKeha0olJ0Nq+04IAKN9epUEtBMjhXDerQP1wGeh 5FnlDnPJVDJvCTLR/YIyjIZJAMXXMEmq+14I7cpnxA2UZgdRFQgDukkUgUgHtsUt Y/tF9Yn1XnJzxysPiXcSsMdMgOGDcWZAszQ4poabTsSiTS3FX5fTMeEQUb5oIxj7 F34AAjfz27rh8VPgmQ55MsuZQW6423vSdjMQzzq7rYk3zHBGTDdvwf23KfeNXZfg MlTRLyeeFin1qXKBMaGoLFDHyo4BkfgMv5fRvOBoa+IcgV1vG5oKlFEUPveZo1EC TJxQqpci+G6Uv28hS9W3Wn8NsDaLWysadrGT5ac2sj8ey4nm65BzBT61TRoBHXo= =MOiK -----END PGP SIGNATURE----- --Nrsi3jtWRpMC807SeA9MrTIf9s3Iish2f--