From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvvLh-0001Si-Dr for qemu-devel@nongnu.org; Fri, 22 May 2015 18:23:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvvLc-0005Gd-H5 for qemu-devel@nongnu.org; Fri, 22 May 2015 18:23:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvvLc-0005GV-CE for qemu-devel@nongnu.org; Fri, 22 May 2015 18:23:20 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 15EFE8E3ED for ; Fri, 22 May 2015 22:23:20 +0000 (UTC) Message-ID: <555FAC57.9080306@redhat.com> Date: Fri, 22 May 2015 16:23:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-13-git-send-email-armbru@redhat.com> In-Reply-To: <1432294585-5984-13-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9sa74l9k9aWRoJQ8PFPweH2m2jr8VQjn9" Subject: Re: [Qemu-devel] [PATCH 12/20] monitor: Inline monitor_has_error() into its only caller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9sa74l9k9aWRoJQ8PFPweH2m2jr8VQjn9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > monitor.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/monitor.c b/monitor.c > index c732203..71ca03f 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -377,11 +377,6 @@ static int GCC_FMT_ATTR(2, 3) monitor_fprintf(FILE= *stream, > return 0; > } > =20 > -static inline int monitor_has_error(const Monitor *mon) > -{ > - return mon->error !=3D NULL; Yay - gets rid of a function returning 0 or 1 instead of a proper bool :)= Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9sa74l9k9aWRoJQ8PFPweH2m2jr8VQjn9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVX6xXAAoJEKeha0olJ0Nq5GgIAJPfqX26XPp0spzxPMWyDIAV bVxJtuBDkUb69S/Hhc0tTsuEmtBXYV5T5NYGY78EiPidTst/uxuCtMMNsU28bSWh b3qg9WEtPuV+tEwHJ85FHxw13ocSMK+QwqBwqItrKlTG52xJfPNVDVb1IpLCqJMO pxE7a7eLANzr2OQR5RoddBMtvTQBpnxWogAs2hukkktckLyir5NRpRt0B4PEmDH/ sfefyUJGNZgwhL7iqTTRf6vpXHHvn/kihC5T4eDPOw1N4V96YxIVh5UqKgHTZeh1 rHfpXaTadn6JNQ4yXu8Hk3SYK38Yhr4/vLe7gjw5+HdpkuXCjspaiK00/Fmwg9c= =qpDG -----END PGP SIGNATURE----- --9sa74l9k9aWRoJQ8PFPweH2m2jr8VQjn9--