Re: [Qemu-devel] [PATCH 15/20] monitor: Rename monitor_control_read(), monitor_control_event()

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1505 bytes --]

On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> ... to monitor_qmp_read(), monitor_qmp_event().
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  monitor.c | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)

Not a trivial rename based on diffstat, but...

> 
> diff --git a/monitor.c b/monitor.c
> index ecadda7..977c0fd 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -5043,10 +5043,7 @@ err_out:
>      QDECREF(args);
>  }
>  
> -/**
> - * monitor_control_read(): Read and handle QMP input
> - */
> -static void monitor_control_read(void *opaque, const uint8_t *buf, int size)
> +static void monitor_qmp_read(void *opaque, const uint8_t *buf, int size)

Drops a comment, but the comment didn't add much.

>  {
>      Monitor *old_mon = cur_mon;
>  
> @@ -5111,10 +5108,7 @@ static QObject *get_qmp_greeting(void)
>      return qobject_from_jsonf("{'QMP':{'version': %p,'capabilities': []}}",ver);
>  }
>  
> -/**
> - * monitor_control_event(): Print QMP gretting
> - */
> -static void monitor_control_event(void *opaque, int event)
> +static void monitor_qmp_event(void *opaque, int event)

Drops a typo in the otherwise useless comment.  (I'm surprised numerous
scans for spelling cleanups haven't yet flagged "gretting" as unusual).

...so I'm okay with it.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]