From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvvoK-0002GG-67 for qemu-devel@nongnu.org; Fri, 22 May 2015 18:53:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvvoF-0002Do-9n for qemu-devel@nongnu.org; Fri, 22 May 2015 18:53:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvvoF-0002DY-00 for qemu-devel@nongnu.org; Fri, 22 May 2015 18:52:55 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4MMqs0F019174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 22 May 2015 18:52:54 -0400 Message-ID: <555FB345.3070402@redhat.com> Date: Fri, 22 May 2015 16:52:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-17-git-send-email-armbru@redhat.com> In-Reply-To: <1432294585-5984-17-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UeDrx48mGbbVwnNVrctb7A4tijM1JsJte" Subject: Re: [Qemu-devel] [PATCH 16/20] monitor: Unbox Monitor member mc and rename to qmp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UeDrx48mGbbVwnNVrctb7A4tijM1JsJte Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/22/2015 05:36 AM, Markus Armbruster wrote: > While there, rename its type as well, from MonitorControl to > MonitorQMP. >=20 > Signed-off-by: Markus Armbruster > --- > monitor.c | 35 ++++++++++++++++------------------- > 1 file changed, 16 insertions(+), 19 deletions(-) >=20 > @@ -5255,14 +5255,11 @@ void monitor_init(CharDriverState *chr, int fla= gs) > monitor_read_command(mon, 0); > } > =20 > - if (monitor_ctrl_mode(mon)) { > - mon->mc =3D g_malloc0(sizeof(MonitorControl)); > - /* Control mode requires special handlers */ > + if (flags & MONITOR_USE_CONTROL) { You also inlined this use of monitor_ctrl_mode; worth mentioning in the commit message? Or should it have been swapped to monitor_is_qmp() in patch 19? Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UeDrx48mGbbVwnNVrctb7A4tijM1JsJte Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVX7NFAAoJEKeha0olJ0NqQqcH+weXd6ls/WdjB7Cw0PNyv7AB o6u/2jodnczo+3dyYn3ooqeH1xgV0jXmscLhlvHUyj4aYunDv/4jgDSX7Z5kmUy+ zEhVh+xqn6c/8AF8KHFMDBXNL+47RBeMNstCt3kmh31mzpxxWiP4zYmjLQfescCO asvKlhCmSMTR3begF/ABbxatb7GYH67g1Cup8UpzEVpS+LZ5KEJZGBRoEx8xJyVh QK1VZRNO/2yo02z89pwd2cbDCiL2NzZ4xrKFa9FpdmmZUfTpaQLgy+IndCrcqj7A CfsaOoGWmDCIrjaME0ugIgLCqmnvCb906gtpS3s4t1fI1pqhaH6pee4iavcfMoY= =orIy -----END PGP SIGNATURE----- --UeDrx48mGbbVwnNVrctb7A4tijM1JsJte--