From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvvrv-0004DS-LA for qemu-devel@nongnu.org; Fri, 22 May 2015 18:56:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yvvrq-0003bf-O3 for qemu-devel@nongnu.org; Fri, 22 May 2015 18:56:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvvrq-0003b8-Ix for qemu-devel@nongnu.org; Fri, 22 May 2015 18:56:38 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 5E4968E74D for ; Fri, 22 May 2015 22:56:37 +0000 (UTC) Message-ID: <555FB424.9050303@redhat.com> Date: Fri, 22 May 2015 16:56:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-19-git-send-email-armbru@redhat.com> In-Reply-To: <1432294585-5984-19-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pbXSuHnBUidK4U2LtuOjwkIL6u9bUjfnu" Subject: Re: [Qemu-devel] [PATCH 18/20] monitor: Turn int command_mode into bool in_command_mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pbXSuHnBUidK4U2LtuOjwkIL6u9bUjfnu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > monitor.c | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) >=20 Might be worth mentioning in the commit message that... > =20 > -static inline int qmp_cmd_mode(const Monitor *mon) > -{ > - return mon->qmp.command_mode; > -} =2E..qmp_cmd_mode() is now inlined into its callers. Nice, fixes up a mis-use of 'int' that I complained about when writing commit 2d5a8346 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --pbXSuHnBUidK4U2LtuOjwkIL6u9bUjfnu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVX7QkAAoJEKeha0olJ0NqrnAH/iNE378tc0p065r2RyO8CQAk 1WN82bnSJR9HFblGBnRqZ+P2X1Ash5Of3teOjiyC0MY8dV6rqbXA00M21zhWjjDw NEPrGo0AJ1lc6E426CAZbpZ35q2NWKPp8kHGV20ZkUcoNFKDLalDKoi4T6jPRKoA mFuo3s5MuWbQdCD/xLwTkp40OFNzC5kK1ODMMD/vHjL9FJCgNv7xKKFAfzF0vdPq uJe8On6FOGJwS2nOLV+F3G+08OYs2TdBQ/cN5NcyRTSz4tETKGadvKXVXDCN+pXJ PymJr9xmG0eQA0xlv8YbXITRmHhqK1YTBXFiD/FaXz6TQ227vV9azJXy4Chxl98= =cHLx -----END PGP SIGNATURE----- --pbXSuHnBUidK4U2LtuOjwkIL6u9bUjfnu--