From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvvvJ-0005Sj-G0 for qemu-devel@nongnu.org; Fri, 22 May 2015 19:00:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvvvE-0004vI-JH for qemu-devel@nongnu.org; Fri, 22 May 2015 19:00:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvvv1-0004Mj-Ct for qemu-devel@nongnu.org; Fri, 22 May 2015 19:00:08 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4MMxssC004104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 22 May 2015 18:59:54 -0400 Message-ID: <555FB4E9.4080301@redhat.com> Date: Fri, 22 May 2015 16:59:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-20-git-send-email-armbru@redhat.com> In-Reply-To: <1432294585-5984-20-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vmq3Q4Hi9fuoDuvfU1mKHnLFiRxlKF7Ho" Subject: Re: [Qemu-devel] [PATCH 19/20] monitor: Rename monitor_ctrl_mode() to monitor_is_qmp() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vmq3Q4Hi9fuoDuvfU1mKHnLFiRxlKF7Ho Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/22/2015 05:36 AM, Markus Armbruster wrote: > ... and change return type to bool. >=20 > Signed-off-by: Markus Armbruster > --- > monitor.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) >=20 See also my review on 16 about a usage in monitor_init(). Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vmq3Q4Hi9fuoDuvfU1mKHnLFiRxlKF7Ho Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVX7TpAAoJEKeha0olJ0NqpbcIAJZPECmqrxp0FEAmvPxjjy5M vz4p9B+LxCddhzANbEx37avll6H/vy4LCycWeUr+XEHMpxz1qQn7Ch4A8pF+ytYt bMHCB7b/9E+x/s73VIEIgapZBB+sZ0dtRD3BSjezJdgcTmYafdFd14N6n8DBYQmu GT/IpxHGFA0u5lCVN2C4kB0x9naE7tU65awWYn0vpEVbFHLBDb+jMl3ajuK1HpNd yHv88rW8HKyv8bKGRYpowZkkLDVaxHYmAp2zv48iVbHn2VNIBGZd68zSZEpECogt O/zgDrTGMwsFfddc4aSN0Ad3vR9T+tebGzTGi2jgAm+K383yjMcfETLTg6TP3OE= =TVZM -----END PGP SIGNATURE----- --vmq3Q4Hi9fuoDuvfU1mKHnLFiRxlKF7Ho--