From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B032AC76188 for ; Tue, 16 Jul 2019 08:42:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84BEB21721 for ; Tue, 16 Jul 2019 08:42:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84BEB21721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnJ2o-0001we-B1 for qemu-devel@archiver.kernel.org; Tue, 16 Jul 2019 04:42:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41291) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnJ2c-0001LY-D2 for qemu-devel@nongnu.org; Tue, 16 Jul 2019 04:42:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnJ2b-0008Ea-9o for qemu-devel@nongnu.org; Tue, 16 Jul 2019 04:42:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12613) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hnJ2Z-00089r-4p; Tue, 16 Jul 2019 04:42:27 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 56BCC87630; Tue, 16 Jul 2019 08:42:25 +0000 (UTC) Received: from [10.72.12.91] (ovpn-12-91.pek2.redhat.com [10.72.12.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id BA06560920; Tue, 16 Jul 2019 08:42:22 +0000 (UTC) To: Ramon Fried , qemu-devel@nongnu.org, qemu-trivial@nongnu.org References: <20190615051722.13994-1-rfried.dev@gmail.com> From: Jason Wang Message-ID: <555fb9b5-361f-fc3f-ff35-38b993a29edd@redhat.com> Date: Tue, 16 Jul 2019 16:42:20 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190615051722.13994-1-rfried.dev@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 16 Jul 2019 08:42:25 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] net: cadence_gem: clear RX control descriptor X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Alistair Francis , "open list:Xilinx Zynq" , "Edgar E. Iglesias" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2019/6/15 =E4=B8=8B=E5=8D=881:17, Ramon Fried wrote: > The RX ring descriptors control field is used for setting > SOF and EOF (start of frame and end of frame). > The SOF and EOF weren't cleared from the previous descriptors, > causing inconsistencies in ring buffer. > Fix that by clearing the control field of every descriptors we're > processing. > > Signed-off-by: Ramon Fried > --- > hw/net/cadence_gem.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c > index ecee22525c..d83a82bdb0 100644 > --- a/hw/net/cadence_gem.c > +++ b/hw/net/cadence_gem.c > @@ -406,6 +406,11 @@ static inline void rx_desc_set_sof(uint32_t *desc) > desc[1] |=3D DESC_1_RX_SOF; > } > =20 > +static inline void rx_desc_clear(uint32_t *desc) Nit: is this better to name this as "rx_desc_clear_control()" ? Thanks > +{ > + desc[1] =3D 0; > +} > + > static inline void rx_desc_set_eof(uint32_t *desc) > { > desc[1] |=3D DESC_1_RX_EOF; > @@ -994,6 +999,8 @@ static ssize_t gem_receive(NetClientState *nc, cons= t uint8_t *buf, size_t size) > bytes_to_copy -=3D MIN(bytes_to_copy, rxbufsize); > =20 > /* Update the descriptor. */ > + rx_desc_clear(s->rx_desc[q]); > + > if (first_desc) { > rx_desc_set_sof(s->rx_desc[q]); > first_desc =3D false;