From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48559)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YwBDz-0006LY-FV
	for qemu-devel@nongnu.org; Sat, 23 May 2015 11:20:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YwBDu-0006kb-Pp
	for qemu-devel@nongnu.org; Sat, 23 May 2015 11:20:31 -0400
Message-ID: <55609AA7.7040907@redhat.com>
Date: Sat, 23 May 2015 17:20:07 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1432102576-6637-1-git-send-email-famz@redhat.com>
	<1432102576-6637-2-git-send-email-famz@redhat.com>
In-Reply-To: <1432102576-6637-2-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 01/13] block: Add op blocker type
	"device IO"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, jcody@redhat.com, armbru@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>, amit.shah@redhat.com, pbonzini@redhat.com

On 20.05.2015 08:16, Fam Zheng wrote:
> It blocks device IO.
>
> All bdrv_op_block_all/blk_op_block_all callers are taken care of:
>
> - virtio_blk_data_plane_create
> - virtio_scsi_hotplug
>
>    Device creation, unblock it.
>
> - bdrv_set_backing_hd
>
>    Backing hd is not used by device, so blocking is OK.
>
> - backup_start
>
>    Blocking target when backup is running, unblock it.
>
> - mirror_complete
>
>    Blocking s->to_replace until mirror_exit, OK.
>
> - block_job_complete
>
>    The block job may be long running. Unblock it.
>
> - init_blk_migration
>
>    The block migration may be long running, Unblock it.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   blockjob.c                      | 1 +
>   hw/block/dataplane/virtio-blk.c | 1 +
>   hw/scsi/virtio-scsi.c           | 1 +
>   include/block/block.h           | 1 +
>   migration/block.c               | 1 +
>   5 files changed, 5 insertions(+)

Reviewed-by: Max Reitz <mreitz@redhat.com>