From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yws7J-0007Tl-9u for qemu-devel@nongnu.org; Mon, 25 May 2015 09:08:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yws7F-0000JA-9M for qemu-devel@nongnu.org; Mon, 25 May 2015 09:08:29 -0400 Received: from mail-wg0-x22b.google.com ([2a00:1450:400c:c00::22b]:33361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yws7F-0000J4-2T for qemu-devel@nongnu.org; Mon, 25 May 2015 09:08:25 -0400 Received: by wgez8 with SMTP id z8so72771282wge.0 for ; Mon, 25 May 2015 06:08:24 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <55631EC5.9030909@redhat.com> Date: Mon, 25 May 2015 15:08:21 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org, rth@twiddle.net, afaerber@suse.de Cc: Peter Crosthwaite On 25/05/2015 08:22, Peter Crosthwaite wrote: > Hi Andreas, Richard and all, > > I'm moving towards the goal of having no core code usages of ENV_GET_CPU. > This has two advantages: > > 1: It means we are closer to common-obj'ing core code like exec.c, cpus.c > and friends. > 2: Multi arch is easier if ENV_GET_CPU stays arch specific. It means I > don't need those patches where I reorder the env within the arch specific > CPUState. This allows continuing placement of arch specifics before the > env in the CPU container (which has TCG perf advantages). > > There's a couple more after this pack to get the multi-arch thing going, > but due to point 1, I'm sending this ahead as I think it has standalone value. > > Regards, > Peter > > Peter Crosthwaite (4): > translate-all: Change tb_flush env argument to cpu > gdbserver: _fork: Change fn to accept cpu instead of env > cpus: Change tcg_cpu_exec arg to cpu, not env > cpus: Change exec_init arg to cpu, not env > > bsd-user/main.c | 2 +- > cpus.c | 7 +++---- > exec.c | 7 +++---- > gdbstub.c | 9 +++------ > include/exec/exec-all.h | 4 ++-- > include/exec/gdbstub.h | 2 +- > linux-user/main.c | 2 +- > linux-user/signal.c | 2 +- > target-alpha/cpu.c | 2 +- > target-alpha/sys_helper.c | 2 +- > target-arm/cpu.c | 2 +- > target-cris/cpu.c | 2 +- > target-i386/cpu.c | 2 +- > target-i386/translate.c | 2 +- > target-lm32/cpu.c | 2 +- > target-m68k/cpu.c | 2 +- > target-microblaze/cpu.c | 2 +- > target-mips/cpu.c | 2 +- > target-moxie/cpu.c | 2 +- > target-openrisc/cpu.c | 2 +- > target-ppc/translate_init.c | 2 +- > target-s390x/cpu.c | 2 +- > target-sh4/cpu.c | 2 +- > target-sparc/cpu.c | 2 +- > target-tricore/cpu.c | 2 +- > target-unicore32/cpu.c | 2 +- > target-xtensa/cpu.c | 2 +- > translate-all.c | 6 ++---- > 28 files changed, 36 insertions(+), 43 deletions(-) > Thanks, queued for 2.4. Paolo