From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52663)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YwtB5-0002Ll-23
	for qemu-devel@nongnu.org; Mon, 25 May 2015 10:16:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YwtAy-00040P-DP
	for qemu-devel@nongnu.org; Mon, 25 May 2015 10:16:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51151)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YwtAy-00040F-8W
	for qemu-devel@nongnu.org; Mon, 25 May 2015 10:16:20 -0400
Message-ID: <55632EAE.9030508@redhat.com>
Date: Mon, 25 May 2015 16:16:14 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <5561EB59.5000407@web.de> <5563225B.60200@redhat.com>
	<55632C7A.8010107@web.de>
In-Reply-To: <55632C7A.8010107@web.de>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] i386: Introduce ARAT CPU feature
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>, Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>



On 25/05/2015 16:06, Jan Kiszka wrote:
>  static void pc_compat_2_3(MachineState *machine)
>  {
> +    x86_cpu_compat_set_features("Westmere", FEAT_6_EAX, 0, CPUID_6_EAX_ARAT);
> +    x86_cpu_compat_set_features("SandyBridge", FEAT_6_EAX, 0,
> +                                CPUID_6_EAX_ARAT);
> +    x86_cpu_compat_set_features("IvyBridge", FEAT_6_EAX, 0, CPUID_6_EAX_ARAT);
> +    x86_cpu_compat_set_features("Haswell-noTSX", FEAT_6_EAX, 0,
> +                                CPUID_6_EAX_ARAT);
> +    x86_cpu_compat_set_features("Haswell", FEAT_6_EAX, 0, CPUID_6_EAX_ARAT);
> +    x86_cpu_compat_set_features("Broadwell-noTSC", FEAT_6_EAX, 0,
> +                                CPUID_6_EAX_ARAT);

noTSX.

Also, I think this doesn't cover Q35.  Eduardo has patches to clean that
up so that (I think) less duplication is required.

Paolo

> +    x86_cpu_compat_set_features("Broadwell", FEAT_6_EAX, 0, CPUID_6_EAX_ARAT);
>  }
>