From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56628)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1YwvCV-0001jp-Vp
	for qemu-devel@nongnu.org; Mon, 25 May 2015 12:26:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1YwvCS-0005Uk-3H
	for qemu-devel@nongnu.org; Mon, 25 May 2015 12:26:03 -0400
Received: from mail-wg0-f52.google.com ([74.125.82.52]:33340)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1YwvCR-0005Ud-Tc
	for qemu-devel@nongnu.org; Mon, 25 May 2015 12:26:00 -0400
Received: by wgez8 with SMTP id z8so76652150wge.0
	for <qemu-devel@nongnu.org>; Mon, 25 May 2015 09:25:59 -0700 (PDT)
Message-ID: <55634D0D.3010103@linaro.org>
Date: Mon, 25 May 2015 18:25:49 +0200
From: Eric Auger <eric.auger@linaro.org>
MIME-Version: 1.0
References: <1432464666-4825-1-git-send-email-christoffer.dall@linaro.org>
	<1432464666-4825-5-git-send-email-christoffer.dall@linaro.org>
	<011b01d096ec$1a395e80$4eac1b80$@samsung.com>
	<CAFEAcA9QWKuh3zjXg_n3HiABEgoXaiRJ8sHMnj=uOzdMGF6yDQ@mail.gmail.com>
In-Reply-To: <CAFEAcA9QWKuh3zjXg_n3HiABEgoXaiRJ8sHMnj=uOzdMGF6yDQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 4/4] target-arm: Add the GICv2m to the
 virt board
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Pavel Fedin <p.fedin@samsung.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Christoffer Dall <christoffer.dall@linaro.org>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>

On 05/25/2015 05:01 PM, Peter Maydell wrote:
> On 25 May 2015 at 14:09, Pavel Fedin <p.fedin@samsung.com> wrote:
>>  Hello!
>>
>>>  typedef struct MemMapEntry {
>>> @@ -88,6 +90,7 @@ typedef struct VirtBoardInfo {
>>>      int fdt_size;
>>>      uint32_t clock_phandle;
>>>      uint32_t gic_phandle;
>>> +    uint32_t v2m_phandle;
>>>  } VirtBoardInfo;
>>
>>  Could you rename v2m_phandle to something more neutral like msi_phandle ? It will also be
>> used by GICv3 ITS implementation.
> 
> Why? The v2m device isn't really related to the GICv3...
In the future this handle could point to GICv2m or GICv3 ITS or GICv3
(if I understand it correctly, when it supports message base interrupts
and no ITS). They all would play the same role of msi-controller.

Best Regards

Eric
> 
> -- PMM
>