From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwzA1-0000Ow-9e for qemu-devel@nongnu.org; Mon, 25 May 2015 16:39:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ywz9y-0007QI-3l for qemu-devel@nongnu.org; Mon, 25 May 2015 16:39:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56190 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ywz9x-0007Q9-Td for qemu-devel@nongnu.org; Mon, 25 May 2015 16:39:42 -0400 Message-ID: <5563888A.5010705@suse.de> Date: Mon, 25 May 2015 22:39:38 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1432511251-22515-1-git-send-email-aurelien@aurel32.net> <1432511251-22515-8-git-send-email-aurelien@aurel32.net> In-Reply-To: <1432511251-22515-8-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/10] target-s390x: enable fully implemented facilities List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org Cc: Richard Henderson On 25.05.15 01:47, Aurelien Jarno wrote: > Cc: Alexander Graf > Cc: Richard Henderson > Signed-off-by: Aurelien Jarno Shouldn't this get populated based on the selected -cpu type? Alex > --- > target-s390x/cpu.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h > index 8bda2e0..35bfdec 100644 > --- a/target-s390x/cpu.h > +++ b/target-s390x/cpu.h > @@ -169,7 +169,7 @@ typedef struct CPUS390XState { > static const uint64_t facilities_dw[] = { > (1ULL << 63) | /* b 0: z/Architecture new instructions added to ESA/390 */ > (1ULL << 62) | /* b 1: z/Architecture architectural */ > - (0ULL << 61) | /* b 2: z/Architecture architectural active */ > + (1ULL << 61) | /* b 2: z/Architecture architectural active */ > (0ULL << 60) | /* b 3: IDTE */ > (0ULL << 59) | /* b 4: IDTE selective clearing when segtab invalidated */ > (0ULL << 58) | /* b 5: IDTE selective clearing when regtab invalidated */ > @@ -188,7 +188,7 @@ static const uint64_t facilities_dw[] = { > (0ULL << 45) | /* b18: Long-displacement facility */ > (0ULL << 44) | /* b19: High performance long-displacement facility */ > (0ULL << 43) | /* b20: HFP-multiply-and-add/subtract facility */ > - (0ULL << 42) | /* b21: Extended-immediate facility */ > + (1ULL << 42) | /* b21: Extended-immediate facility */ > (0ULL << 41) | /* b22: Extended-translation facility 3 */ > (0ULL << 40) | /* b23: HFP-unnormalized-extension facility */ > (0ULL << 39) | /* b24: ETF2-enhancement facility */ > @@ -201,7 +201,7 @@ static const uint64_t facilities_dw[] = { > (0ULL << 31) | /* b32: Compare-and-swap-and-store facility */ > (0ULL << 30) | /* b33: Compare-and-swap-and-store facility 2 */ > (0ULL << 29) | /* b34: General-instructions-extension facility */ > - (0ULL << 28) | /* b35: Execute-extensions facility */ > + (1ULL << 28) | /* b35: Execute-extensions facility */ > (0ULL << 27) | /* b36: Enhanced-monitor facility */ > (0ULL << 26) | /* b37: Floating-point extension facility */ > (0ULL << 24) | /* b39: IBM internal use */ >