From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx9z2-0007nn-R8 for qemu-devel@nongnu.org; Tue, 26 May 2015 04:13:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yx9yz-0005z8-1L for qemu-devel@nongnu.org; Tue, 26 May 2015 04:13:08 -0400 Message-ID: <55642B01.3010305@redhat.com> Date: Tue, 26 May 2015 10:12:49 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1432622302-6798-1-git-send-email-crosthwaite.peter@gmail.com> In-Reply-To: <1432622302-6798-1-git-send-email-crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory_mapping: Use qemu_common.h include List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Peter Crosthwaite On 26/05/2015 08:38, Peter Crosthwaite wrote: > Rather than an explicit inclusion of cpu.h. This maked it more > consistent with other core code files, which either just rely on > qemu-common.h inclusion or preceed cpu.h with qemu-common.h anyway. I'd rather keep the cpu.h inclusion. It would be nice to get rid of the automagic inclusion of cpu.h from qemu-common.h. Paolo > Signed-off-by: Peter Crosthwaite > --- > Picked up by my multi arch WIP where target-multi/cpu.h cant handle > random core code inclusion without preceeded qemu-common.h. I guess > this is the only one in tree? > --- > memory_mapping.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/memory_mapping.c b/memory_mapping.c > index 7b69801..7cf5548 100644 > --- a/memory_mapping.c > +++ b/memory_mapping.c > @@ -13,8 +13,7 @@ > > #include > > -#include "cpu.h" > -#include "exec/cpu-all.h" > +#include "qemu-common.h" > #include "sysemu/memory_mapping.h" > #include "exec/memory.h" > #include "exec/address-spaces.h" > -- 1.9.1