From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxA0A-0000i9-DM for qemu-devel@nongnu.org; Tue, 26 May 2015 04:14:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxA07-0006KH-91 for qemu-devel@nongnu.org; Tue, 26 May 2015 04:14:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxA07-0006K7-4o for qemu-devel@nongnu.org; Tue, 26 May 2015 04:14:15 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id DC5AB8E3CE for ; Tue, 26 May 2015 08:14:14 +0000 (UTC) Message-ID: <55642B50.50206@redhat.com> Date: Tue, 26 May 2015 10:14:08 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com> <1430152117-100558-4-git-send-email-pbonzini@redhat.com> <20150526071341.GD13749@ad.nay.redhat.com> In-Reply-To: <20150526071341.GD13749@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/29] display: enable DIRTY_MEMORY_VGA tracking explicitly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On 26/05/2015 09:13, Fam Zheng wrote: >> > hw/display/cg3.c | 1 + >> > hw/display/exynos4210_fimd.c | 20 +++++++++++++------- >> > hw/display/g364fb.c | 1 + >> > hw/display/sm501.c | 1 + >> > hw/display/tcx.c | 1 + >> > 5 files changed, 17 insertions(+), 7 deletions(-) > "git grep memory_region_init_ram hw/display/" also mentions qxl.vram, vga.vram, > tc6393xb.vram and vga.vram. Why don't these need it? tc6393xb.c doesn't use dirty memory, and vga sets it in hw/display/vga.c. Paolo