From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxA0q-0001Xq-9n for qemu-devel@nongnu.org; Tue, 26 May 2015 04:15:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxA0m-0006TS-JZ for qemu-devel@nongnu.org; Tue, 26 May 2015 04:15:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxA0m-0006TC-Co for qemu-devel@nongnu.org; Tue, 26 May 2015 04:14:56 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4Q8EtcM011654 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 26 May 2015 04:14:55 -0400 Message-ID: <55642B76.1000604@redhat.com> Date: Tue, 26 May 2015 10:14:46 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com> <1430152117-100558-5-git-send-email-pbonzini@redhat.com> <20150526073657.GE13749@ad.nay.redhat.com> In-Reply-To: <20150526073657.GE13749@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/29] display: add memory_region_sync_dirty_bitmap calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On 26/05/2015 09:36, Fam Zheng wrote: > On Mon, 04/27 18:28, Paolo Bonzini wrote: >> diff --git a/hw/display/tcx.c b/hw/display/tcx.c >> index 58faa96..2eb5aef 100644 >> --- a/hw/display/tcx.c >> +++ b/hw/display/tcx.c >> @@ -353,6 +353,7 @@ static void tcx_update_display(void *opaque) >> return; >> } >> >> + memory_region_sync_dirty_bitmap(&ts->vram_mem); >> for (y = 0; y < ts->height; page += TARGET_PAGE_SIZE) { >> if (memory_region_get_dirty(&ts->vram_mem, page, TARGET_PAGE_SIZE, >> DIRTY_MEMORY_VGA)) { > > Why not change tcx24_update_display as well? You're right. Paolo