From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxA6n-0006y2-BE for qemu-devel@nongnu.org; Tue, 26 May 2015 04:21:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxA6i-0000OO-HR for qemu-devel@nongnu.org; Tue, 26 May 2015 04:21:09 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53376 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxA6i-0000O3-AF for qemu-devel@nongnu.org; Tue, 26 May 2015 04:21:04 -0400 Message-ID: <55642CE6.6040004@suse.de> Date: Tue, 26 May 2015 10:20:54 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <55631EC5.9030909@redhat.com> <55640E70.1080306@suse.de> <55642961.2080409@redhat.com> In-Reply-To: <55642961.2080409@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , Peter Crosthwaite , rth@twiddle.net, qemu-devel@nongnu.org, Peter Crosthwaite Am 26.05.2015 um 10:05 schrieb Paolo Bonzini: > On 26/05/2015 08:10, Andreas F=C3=A4rber wrote: >> Am 25.05.2015 um 15:08 schrieb Paolo Bonzini: >>> On 25/05/2015 08:22, Peter Crosthwaite wrote: >>>> Hi Andreas, Richard and all, >>>> >>>> I'm moving towards the goal of having no core code usages of ENV_GET= _CPU. >>>> This has two advantages: >>>> >>>> 1: It means we are closer to common-obj'ing core code like exec.c, c= pus.c >>>> and friends. >>>> 2: Multi arch is easier if ENV_GET_CPU stays arch specific. It means= I >>>> don't need those patches where I reorder the env within the arch spe= cific >>>> CPUState. This allows continuing placement of arch specifics before = the >>>> env in the CPU container (which has TCG perf advantages). >>>> >>>> There's a couple more after this pack to get the multi-arch thing go= ing, >>>> but due to point 1, I'm sending this ahead as I think it has standal= one value. >>>> >>>> Regards, >>>> Peter >>>> >>>> Peter Crosthwaite (4): >>>> translate-all: Change tb_flush env argument to cpu >>>> gdbserver: _fork: Change fn to accept cpu instead of env >>>> cpus: Change tcg_cpu_exec arg to cpu, not env >>>> cpus: Change exec_init arg to cpu, not env >> [...] >>> >>> Thanks, queued for 2.4. >> >> Apparently after qom-next you also want to take over qom-cpu, once aga= in >> without pinging me first. >=20 > Uhm... >=20 > Main loop > M: Paolo Bonzini > S: Maintained > F: cpus.c > F: main-loop.c > F: qemu-timer.c > F: vl.c >=20 > translate-all.c is "Odd fixes" with no specific maintainer, and > gdbserver.c is not in MAINTAINERS altogether. ENV_GET_CPU() is my QOM CPU macro. You picked the patchset up just hours after it arrived on the list, on a holiday, without giving me a chance to review. It's not about which tree it goes through, it's about you not asking first - which I reminded you of just days ago, so this appears deliberate. And as you can see above, the cover letter was addressed to Richard and me, so we should get a chance to respond a) with change requests and b) with Reviewed-bys or Acked-bys that actually get put on the patch and not repeatedly ignored like on your last pull. Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)