From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxAJ7-0006fd-In for qemu-devel@nongnu.org; Tue, 26 May 2015 04:33:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxAJ2-0006pP-JV for qemu-devel@nongnu.org; Tue, 26 May 2015 04:33:53 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53997 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxAJ2-0006pB-Dx for qemu-devel@nongnu.org; Tue, 26 May 2015 04:33:48 -0400 Message-ID: <55642FEA.6020006@suse.de> Date: Tue, 26 May 2015 10:33:46 +0200 From: Alexander Graf MIME-Version: 1.0 References: <55631EC5.9030909@redhat.com> <55640E70.1080306@suse.de> <55642961.2080409@redhat.com> <55642CE6.6040004@suse.de> <55642E04.6060902@redhat.com> <55642F4F.20707@suse.de> In-Reply-To: <55642F4F.20707@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Paolo Bonzini Cc: Peter Maydell , Juan Quintela , Peter Crosthwaite , qemu-devel@nongnu.org, Peter Crosthwaite , rth@twiddle.net On 26.05.15 10:31, Andreas F=C3=A4rber wrote: > Am 26.05.2015 um 10:25 schrieb Paolo Bonzini: >> >> >> On 26/05/2015 10:20, Andreas F=C3=A4rber wrote: >>> Am 26.05.2015 um 10:05 schrieb Paolo Bonzini: >>>> On 26/05/2015 08:10, Andreas F=C3=A4rber wrote: >>>>> Am 25.05.2015 um 15:08 schrieb Paolo Bonzini: >>>>>> On 25/05/2015 08:22, Peter Crosthwaite wrote: >>>>>>> Hi Andreas, Richard and all, >>>>>>> >>>>>>> I'm moving towards the goal of having no core code usages of ENV_= GET_CPU. >>>>>>> This has two advantages: >>>>>>> >>>>>>> 1: It means we are closer to common-obj'ing core code like exec.c= , cpus.c >>>>>>> and friends. >>>>>>> 2: Multi arch is easier if ENV_GET_CPU stays arch specific. It me= ans I >>>>>>> don't need those patches where I reorder the env within the arch = specific >>>>>>> CPUState. This allows continuing placement of arch specifics befo= re the >>>>>>> env in the CPU container (which has TCG perf advantages). >>>>>>> >>>>>>> There's a couple more after this pack to get the multi-arch thing= going, >>>>>>> but due to point 1, I'm sending this ahead as I think it has stan= dalone value. >>>>>>> >>>>>>> Regards, >>>>>>> Peter >>>>>>> >>>>>>> Peter Crosthwaite (4): >>>>>>> translate-all: Change tb_flush env argument to cpu >>>>>>> gdbserver: _fork: Change fn to accept cpu instead of env >>>>>>> cpus: Change tcg_cpu_exec arg to cpu, not env >>>>>>> cpus: Change exec_init arg to cpu, not env >>>>> [...] >>>>>> >>>>>> Thanks, queued for 2.4. >>>>> >>>>> Apparently after qom-next you also want to take over qom-cpu, once = again >>>>> without pinging me first. >>>> >>>> Uhm... >>>> >>>> Main loop >>>> M: Paolo Bonzini >>>> S: Maintained >>>> F: cpus.c >>>> F: main-loop.c >>>> F: qemu-timer.c >>>> F: vl.c >>>> >>>> translate-all.c is "Odd fixes" with no specific maintainer, and >>>> gdbserver.c is not in MAINTAINERS altogether. >>> >>> ENV_GET_CPU() is my QOM CPU macro. >> >> Please, this is ridiculous. MAINTAINERS talks about files, not about >> macros. If somebody misuses the memory API and I'm on vacation (I kno= w >> you're not, this is an example), I fix it myself, I don't complain wit= h >> whomever applied the patches. >> >>> You picked the patchset up just hours >>> after it arrived on the list, on a holiday, without giving me a chanc= e >>> to review. It's not about which tree it goes through, it's about you = not >>> asking first - which I reminded you of just days ago, so this appears >>> deliberate. >> >> It certainly is. >=20 > Then you can fix up Daniel's patch yourself and I am stepping down as > maintainer. Have fun. Please take a big breath and don't do the Jocelyn Mayer thing ;). How about we have the KVM call today and calmly talk about maintainer responsibility borders? Alex