From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxApf-0005Oo-St for qemu-devel@nongnu.org; Tue, 26 May 2015 05:07:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxApc-0001oN-47 for qemu-devel@nongnu.org; Tue, 26 May 2015 05:07:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxApb-0001oJ-Uw for qemu-devel@nongnu.org; Tue, 26 May 2015 05:07:28 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id B07CA8E79D for ; Tue, 26 May 2015 09:07:27 +0000 (UTC) Message-ID: <556437CA.40605@redhat.com> Date: Tue, 26 May 2015 11:07:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com> <1430152117-100558-12-git-send-email-pbonzini@redhat.com> <20150526084031.GL13749@ad.nay.redhat.com> In-Reply-To: <20150526084031.GL13749@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/29] memory: include DIRTY_MEMORY_MIGRATION in the dirty log mask List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On 26/05/2015 10:40, Fam Zheng wrote: >> > void memory_global_dirty_log_stop(void) >> > { >> > + /* Refresh DIRTY_LOG_MIGRATION bit. */ >> > + memory_region_transaction_begin(); >> > + memory_region_update_pending = true; >> > + memory_region_transaction_commit(); >> > + >> > global_dirty_log = false; > Shouldn't this go before memory_region_transaction_begin? Yes. Paolo