From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxD1n-000687-Ex for qemu-devel@nongnu.org; Tue, 26 May 2015 07:28:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxD1k-0008Pw-8k for qemu-devel@nongnu.org; Tue, 26 May 2015 07:28:11 -0400 Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:33467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxD1k-0008Pr-0a for qemu-devel@nongnu.org; Tue, 26 May 2015 07:28:08 -0400 Received: by wgez8 with SMTP id z8so94221402wge.0 for ; Tue, 26 May 2015 04:28:07 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <556458C4.6050405@redhat.com> Date: Tue, 26 May 2015 13:28:04 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com> <1430152117-100558-20-git-send-email-pbonzini@redhat.com> <20150526110801.GR13749@ad.nay.redhat.com> In-Reply-To: <20150526110801.GR13749@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 19/29] exec: pass client mask to cpu_physical_memory_set_dirty_range List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On 26/05/2015 13:08, Fam Zheng wrote: >> > + if (likely(mask & (1 << DIRTY_MEMORY_MIGRATION))) { >> > + bitmap_set(ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION], page, end - page); > Wrap the line? Other than that: > > Reviewed-by: Fam Zheng Yes, the line gets shorter at the end of the series. Paolo