From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxD8j-00022Y-CR for qemu-devel@nongnu.org; Tue, 26 May 2015 07:35:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxD8e-00043m-BI for qemu-devel@nongnu.org; Tue, 26 May 2015 07:35:21 -0400 Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:37931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxD8e-00043S-0G for qemu-devel@nongnu.org; Tue, 26 May 2015 07:35:16 -0400 Received: by wichy4 with SMTP id hy4so77932752wic.1 for ; Tue, 26 May 2015 04:35:15 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <55645A6F.4040702@redhat.com> Date: Tue, 26 May 2015 13:35:11 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com> <1430152117-100558-6-git-send-email-pbonzini@redhat.com> <20150526074634.GF13749@ad.nay.redhat.com> In-Reply-To: <20150526074634.GF13749@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/29] memory: differentiate memory_region_is_logging and memory_region_get_dirty_log_mask List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On 26/05/2015 09:46, Fam Zheng wrote: >> > * >> > - * Returns %true if the memory region is logging writes >> > + * Returns %true if the memory region is logging writes for the given client >> > + * a bitmap of clients for which the memory region is logging writes. > I can't parse this sentence, rephrase a bit? The second line is stail >> > * >> > * @mr: the memory region being queried >> > + * @client: the client being queried >> > */ >> > -bool memory_region_is_logging(MemoryRegion *mr); >> > +bool memory_region_is_logging(MemoryRegion *mr, uint8_t client); >> > + >> > +/** >> > + * memory_region_get_dirty_log_mask: return the clients for which a > s/which a/ which the/ ? "a" is consistent with "memory_region_name: get a memory region's name", for example. >> > + * memory region is logging writes. >> > + * >> > + * Returns a bitmap of clients for which the memory region is logging writes. > Why repeat? Just a consequence of how the doc comments are written. For some functions the summary is the same as the description of the return value. I'll change it to just "Returns a bitmap of clients, which right now will be either 0 or (1 << DIRTY_MEMORY_VGA)". Paolo > All questions are trivial enough that once you fix them or if they don't need > fixing: > > Reviewed-by: Fam Zheng >