From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Fam Zheng <famz@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 03/29] display: enable DIRTY_MEMORY_VGA tracking explicitly
Date: Tue, 26 May 2015 13:56:49 +0200 [thread overview]
Message-ID: <55645F81.5070206@redhat.com> (raw)
In-Reply-To: <CAFEAcA8rX6DqBpRo3djJDCLuLAL_r=aXr-+mECgEPBo++mVk1w@mail.gmail.com>
On 26/05/2015 13:52, Peter Maydell wrote:
> On 26 May 2015 at 12:24, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> > Peter, Mark, Aurelien, can you review and ack this patch?
> Could you provide some explanation/documentation of when a
> display device needs to set DIRTY_MEMORY_VGA (and when it
> doesn't)?
It needs to set it if it uses memory_region_get/set/clear_dirty with
DIRTY_MEMORY_VGA as the last argument.
> If we get it wrong is there any way to make qemu
> assert or otherwise catch the error?
It may be possible to check against mr->dirty_log_mask in
memory_region_get/set/clear_dirty. However, it is just as likely to
have some corner case that is correct but triggers the assertion.
I haven't thought much about it, because a simple grep for
DIRTY_MEMORY_VGA will catch the device models that need care.
Paolo
next prev parent reply other threads:[~2015-05-26 11:57 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 16:28 [Qemu-devel] [PATCH v2 00/29] Dirty bitmap atomic access and optimizations Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 01/29] memory: the only dirty memory flag for users is DIRTY_MEMORY_VGA Paolo Bonzini
2015-05-26 7:00 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 02/29] g364fb: remove pointless call to memory_region_set_coalescing Paolo Bonzini
2015-05-26 12:53 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 03/29] display: enable DIRTY_MEMORY_VGA tracking explicitly Paolo Bonzini
2015-05-26 7:13 ` Fam Zheng
2015-05-26 8:14 ` Paolo Bonzini
2015-05-26 11:24 ` Paolo Bonzini
2015-05-26 11:52 ` Peter Maydell
2015-05-26 11:56 ` Paolo Bonzini [this message]
2015-05-26 12:08 ` Peter Maydell
2015-05-26 12:10 ` Paolo Bonzini
2015-05-26 12:16 ` Peter Maydell
2015-05-31 20:32 ` Mark Cave-Ayland
2015-04-27 16:28 ` [Qemu-devel] [PATCH 04/29] display: add memory_region_sync_dirty_bitmap calls Paolo Bonzini
2015-05-26 7:36 ` Fam Zheng
2015-05-26 8:14 ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 05/29] memory: differentiate memory_region_is_logging and memory_region_get_dirty_log_mask Paolo Bonzini
2015-05-26 7:46 ` Fam Zheng
2015-05-26 11:35 ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 06/29] memory: prepare for multiple bits in the dirty log mask Paolo Bonzini
2015-05-26 7:55 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 07/29] framebuffer: check memory_region_is_logging Paolo Bonzini
2015-05-26 8:02 ` Fam Zheng
2015-05-26 11:16 ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 08/29] ui/console: remove dpy_gfx_update_dirty Paolo Bonzini
2015-05-26 8:03 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 09/29] memory: track DIRTY_MEMORY_CODE in mr->dirty_log_mask Paolo Bonzini
2015-05-26 8:06 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 10/29] kvm: accept non-mapped memory in kvm_dirty_pages_log_change Paolo Bonzini
2015-05-26 8:10 ` Fam Zheng
2015-05-26 8:16 ` Paolo Bonzini
2015-05-26 8:22 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 11/29] memory: include DIRTY_MEMORY_MIGRATION in the dirty log mask Paolo Bonzini
2015-05-26 8:40 ` Fam Zheng
2015-05-26 9:07 ` Paolo Bonzini
2015-05-26 9:22 ` Fam Zheng
2015-05-26 9:26 ` Paolo Bonzini
2015-05-26 9:48 ` Fam Zheng
2015-05-26 9:07 ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 12/29] kvm: remove special handling of " Paolo Bonzini
2015-05-26 8:56 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 13/29] ram_addr: tweaks to xen_modified_memory Paolo Bonzini
2015-05-26 12:52 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 14/29] exec: use memory_region_get_dirty_log_mask to optimize dirty tracking Paolo Bonzini
2015-05-26 10:42 ` Fam Zheng
2015-05-26 10:58 ` Paolo Bonzini
2015-05-26 11:12 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 15/29] exec: move functions to translate-all.h Paolo Bonzini
2015-05-26 10:50 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 16/29] translate-all: remove unnecessary argument to tb_invalidate_phys_range Paolo Bonzini
2015-05-26 10:51 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 17/29] cputlb: remove useless arguments to tlb_unprotect_code_phys, rename Paolo Bonzini
2015-05-26 10:53 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 18/29] translate-all: make less of tb_invalidate_phys_page_range depend on is_cpu_write_access Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 19/29] exec: pass client mask to cpu_physical_memory_set_dirty_range Paolo Bonzini
2015-05-26 11:08 ` Fam Zheng
2015-05-26 11:28 ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 20/29] exec: invert return value of cpu_physical_memory_get_clean, rename Paolo Bonzini
2015-05-26 11:26 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 21/29] exec: only check relevant bitmaps for cleanliness Paolo Bonzini
2015-05-26 11:31 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 22/29] memory: do not touch code dirty bitmap unless TCG is enabled Paolo Bonzini
2015-05-26 11:33 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 23/29] bitmap: add atomic set functions Paolo Bonzini
2015-05-26 11:54 ` Fam Zheng
2015-05-26 11:58 ` Paolo Bonzini
2015-05-26 12:36 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 24/29] bitmap: add atomic test and clear Paolo Bonzini
2015-05-26 12:27 ` Fam Zheng
2015-05-26 12:32 ` Fam Zheng
2015-05-26 12:33 ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 25/29] memory: use atomic ops for setting dirty memory bits Paolo Bonzini
2015-05-26 12:29 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 26/29] migration: move dirty bitmap sync to ram_addr.h Paolo Bonzini
2015-05-26 12:34 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 27/29] memory: replace cpu_physical_memory_reset_dirty() with test-and-clear Paolo Bonzini
2015-05-26 12:42 ` Fam Zheng
2015-05-26 12:45 ` Paolo Bonzini
2015-04-27 16:28 ` [Qemu-devel] [PATCH 28/29] memory: make cpu_physical_memory_sync_dirty_bitmap() fully atomic Paolo Bonzini
2015-05-26 12:45 ` Fam Zheng
2015-04-27 16:28 ` [Qemu-devel] [PATCH 29/29] memory: strengthen assertions on mr->terminates Paolo Bonzini
2015-05-26 12:49 ` Fam Zheng
2015-05-26 12:52 ` Paolo Bonzini
2015-05-26 12:56 ` Fam Zheng
2015-05-25 21:50 ` [Qemu-devel] [PATCH v2 00/29] Dirty bitmap atomic access and optimizations Paolo Bonzini
2015-05-26 12:58 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55645F81.5070206@redhat.com \
--to=pbonzini@redhat.com \
--cc=aurelien@aurel32.net \
--cc=famz@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).