From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxDVC-00062k-K9 for qemu-devel@nongnu.org; Tue, 26 May 2015 07:58:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxDV8-0003rv-EU for qemu-devel@nongnu.org; Tue, 26 May 2015 07:58:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxDV8-0003rp-9H for qemu-devel@nongnu.org; Tue, 26 May 2015 07:58:30 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id C3A0756 for ; Tue, 26 May 2015 11:58:29 +0000 (UTC) Message-ID: <55645FE1.3030007@redhat.com> Date: Tue, 26 May 2015 13:58:25 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com> <1430152117-100558-24-git-send-email-pbonzini@redhat.com> <20150526115416.GV13749@ad.nay.redhat.com> In-Reply-To: <20150526115416.GV13749@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 23/29] bitmap: add atomic set functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On 26/05/2015 13:54, Fam Zheng wrote: > > +void bitmap_set_atomic(unsigned long *map, long start, long nr) > > +{ > > + unsigned long *p = map + BIT_WORD(start); > > + const long size = start + nr; > > s/size/end/ ? That is consistent with bitmap_set, but we could consider changing it there too. Paolo > Otherwise, > > Reviewed-by: Fam Zheng >