From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38249)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YxDh2-0002KJ-Aj
	for qemu-devel@nongnu.org; Tue, 26 May 2015 08:10:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YxDgy-0003rk-2A
	for qemu-devel@nongnu.org; Tue, 26 May 2015 08:10:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33150)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YxDgx-0003re-PR
	for qemu-devel@nongnu.org; Tue, 26 May 2015 08:10:43 -0400
Message-ID: <556462A7.8000208@redhat.com>
Date: Tue, 26 May 2015 14:10:15 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com>
	<1430152117-100558-4-git-send-email-pbonzini@redhat.com>
	<556457F5.7050607@redhat.com>
	<CAFEAcA8rX6DqBpRo3djJDCLuLAL_r=aXr-+mECgEPBo++mVk1w@mail.gmail.com>
	<55645F81.5070206@redhat.com>
	<CAFEAcA9iiTfTcL05aKq8WU65N2wtBjw1xvdg2NtFFvhrOXE=Ew@mail.gmail.com>
In-Reply-To: <CAFEAcA9iiTfTcL05aKq8WU65N2wtBjw1xvdg2NtFFvhrOXE=Ew@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/29] display: enable DIRTY_MEMORY_VGA
	tracking explicitly
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Fam Zheng <famz@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>



On 26/05/2015 14:08, Peter Maydell wrote:
>>> >> Could you provide some explanation/documentation of when a
>>> >> display device needs to set DIRTY_MEMORY_VGA (and when it
>>> >> doesn't)?
>> >
>> > It needs to set it if it uses memory_region_get/set/clear_dirty with
>> > DIRTY_MEMORY_VGA as the last argument.
> OK, and which devices need to do that?

Those that care to optimize their update_display callback.  It's
entirely opt in.

Paolo